Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies required in @rancher/shell for external cases, removed with migration #12318

Closed
aalves08 opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/enhancement kind/tech-debt Technical debt QA/None
Milestone

Comments

@aalves08
Copy link
Member

aalves08 commented Oct 22, 2024

Is your feature request related to a problem? Please describe.

After the migration to Vue3, some libraries are required for external cases when providing the files as @rancher/shell library, e.g. for extensions. This is a known consequence for removing nuxt dependency, since we were importing/using these libraries without define them in the project or shell library.

Describe the solution you'd like
Add these libraries to ./shell/package.json

    "cache-loader": "^4.1.0",
    "color": "4.2.3",
    "ip": "2.0.1",
    "node-polyfill-webpack-plugin": "^3.0.0"

Describe alternatives you've considered
None.

Additional context

These libraries were added in the example as a requirement to make them work, but as @aalves08 pointed out, they should be already included in the @rancher/shell library and avoid adding in each extension.

Example to avoid, done to make it work: https://github.com/rancher/ui-plugin-examples/blob/main/pkg/clock/package.json#L20C44-L24C45

@aalves08 aalves08 added kind/enhancement kind/tech-debt Technical debt area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Oct 22, 2024
@cnotv cnotv changed the title Investigate possible duplication of libraries between shell and dashboard Add missing dependencies required in @rancher/shell for external cases, removed with migration Oct 22, 2024
@cnotv cnotv added this to the v2.10.0 milestone Oct 22, 2024
@cnotv
Copy link
Member

cnotv commented Oct 22, 2024

Sorry I messed up with the issues and I noticed now that we have #12319, let's keep this one #12320

@cnotv cnotv closed this as completed Oct 22, 2024
@aalves08 aalves08 self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/enhancement kind/tech-debt Technical debt QA/None
Projects
None yet
Development

No branches or pull requests

2 participants