Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors not showing in fleet git repo form #12425

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

richard-cox
Copy link
Member

Summary

Fixes #12391

Occurred changes and/or fixed issues

Missed from

Technical notes summary

i could reproduce this in release-2.9 head

Areas or cases that should be tested

git repo create / edit with failures
given recent git repo url change though to reproduce an easy error try creating a git repo with a name of an existing one

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Oct 30, 2024
@richard-cox richard-cox requested a review from momesgin October 30, 2024 11:23
@richard-cox richard-cox self-assigned this Oct 30, 2024
@gaktive gaktive requested a review from momesgin October 30, 2024 15:27
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, and lgtm

@richard-cox
Copy link
Member Author

@momesgin I gave this another go and it looks ok. could you provide some repro steps for the failure (to show the failure)?

image

@momesgin
Copy link
Member

@momesgin I gave this another go and it looks ok. could you provide some repro steps for the failure (to show the failure)?

image

I acted fast and did a re-test before your comment 😁, already approved 🚀

@nwmac nwmac merged commit 336e765 into rancher:master Oct 31, 2024
33 checks passed
@richard-cox richard-cox deleted the fix-git-repo-error branch January 15, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fleet: Git Repo: Error is not shown when adding git repo
3 participants