Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test v-model.number usage in 2.10 / vue3 world #12428

Closed
richard-cox opened this issue Oct 30, 2024 · 2 comments · Fixed by #12441
Closed

Test v-model.number usage in 2.10 / vue3 world #12428

richard-cox opened this issue Oct 30, 2024 · 2 comments · Fixed by #12441
Assignees
@aalves08 @yonasberhe23 @momesgin
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/tech-debt Technical debt
Milestone
v2.10.0

Comments

@richard-cox
Copy link
Member

richard-cox commented Oct 30, 2024 •
edited by yonasberhe23
Loading

Screen Recording:
https://github.com/user-attachments/assets/7dbfc1f7-df5f-4747-8836-9eaa01203d82
@richard-cox richard-cox added kind/tech-debt Technical debt area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Oct 30, 2024
@richard-cox richard-cox added this to the v2.10.0 milestone Oct 30, 2024
@gaktive
Copy link
Member

gaktive commented Oct 30, 2024

We may be lucky in that usage of this variable is light so we could push this out to 2.11.0 with a backport but we should know how we look for 2.10.0.

@aalves08 aalves08 mentioned this issue Oct 31, 2024
Merged
7 tasks
@aalves08 aalves08 self-assigned this Oct 31, 2024
@nwmac nwmac removed the QA/None label Oct 31, 2024
@nwmac nwmac reopened this Oct 31, 2024
@yonasberhe23 yonasberhe23 self-assigned this Oct 31, 2024
@yonasberhe23
Copy link
Contributor

Unit input for unhealthy node timeout on machine pools in cluster provisioning fixed.

Tested in:

  • Rancher v2.10-e2d0b42c91253243696d36f09e8e6e23cc6fb0db-head
  • Dashboard master 10e5e5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalves08 aalves08

@yonasberhe23 yonasberhe23

@momesgin momesgin

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/tech-debt Technical debt
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Test v-model.number usage in 2.10 / vue3 world - fix broken unitInput aalves08/dashboard
6 participants
@nwmac @gaktive @richard-cox @aalves08 @yonasberhe23 @momesgin