CIS Benchmark's Scan detail page config tab fails to show schedule info when scan is pending

[richard-cox]

Setup

• Rancher version: 2.9 (at least)

Describe the bug

• cis scan detail page config tab should show schedule info regardless of running state of scan

To Reproduce

• install cis benchmark
• create a scan
  • supply schedule
• kick off a scan
• navigate quickly to detail page config tab (or ensure scan stays in pending state given queue of scans)

Result

• no schedule info is shown

Expected Result

Screenshots

Additional context

• caused by

  dashboard/shell/edit/cis.cattle.io.clusterscan.vue

  Lines 112 to 120 in 001b6e9

  	canBeScheduled() {
  	// check if scan was created and run with an older cis install that doesn't support scheduling/alerting/warn state
  	if (this.mode === _VIEW) {
  	const warn = get(this.value, 'status.summary.warn');
  	return !!warn || warn === 0;
  	}
  	return this.value.canBeScheduled();

  • warn is undefined, therefore canBeScheduled is false, so radio button and schedule settings not shown
  • probably can remove this.mode if block ?
• detail page doesn't do anything fancy, just looks at value.canBeScheduled -

  dashboard/shell/detail/cis.cattle.io.clusterscan.vue

  Lines 56 to 58 in 001b6e9

  	canBeScheduled() {
  	return this.value.canBeScheduled();
  	},