As custom user incorrect fleet gitrepos are shown given the workspace filter

[mmartin24]

Setup

• Rancher version: 2.10.0-alpha5
• Rancher UI Extensions:
• Browser type & version:Brave 1.70

Describe the bug
After an admin deploys 2 girepos one in fleet-local and the other in fleet-default, an user with access to these gitrepos will see them in incorrect order when using the toggle (the ones meant to be in local will appear in default and the one in default will appear in local)

To Reproduce

• Deploy Rancher 2.10.0-alpha5 with at least 1 downstream cluster
• As an admin deploy these 2 gitrepos:
  Local cluster

Name: fleet-local-simple-chart
URL: https://github.com/rancher/fleet-test-data
branch: master
path: simple-chart

Default cluster

Name: fleet-default-nginx
URL: https://github.com/rancher/fleet-test-data
branch: master
path: qa-test-apps/nginx-app

• Create standard user std-user-46 with this custom roles:

 { resource: "fleetworkspaces", verbs: ["create", "delete", "get", "list", "patch", "update", "watch"]},
 { resource: "gitrepos", verbs: ["list"]},
 { resource: "bundles", verbs: ["create", "delete", "get", "list", "patch", "update", "watch"]},

• Access as std-user-46

Result
When navigating to gitrepos std-user-46 sees:

• when changing toggle to fleet-local gitrepo fleet-default-nginx
• when changing toggle to fleet-default gitrepo fleet-local-simple-chart
  

Expected Result
When navigating to gitrepos std-user-46 should see:

• when changing toggle to fleet-local gitrepo fleet-local-simple-chart
• when changing toggle to fleet-default gitrepo fleet-default-nginx

Screenshots

Screencast.from.30-10-24.17.15.59.webm

Additional context

[richard-cox]

@mmartin24 can you confirm how you created the two git repos? it would be expected that the git repo is created in the workspace that was selected at the time of creation

Edit: this can be confirmed by looking at the metadata.namespace of the gitrepo

[eva-vashkevich]

@gaktive should I look into this and try to fit it in 2.10?

[richard-cox]

@eva-vashkevich if it's reproducible and a regression we should try. if it's not reproducible or a regression it can definitely be pushed to 2.11. In master i couldn't reproduce, the gitrepos appear in the workspace they were created in

[eva-vashkevich]

I am able to reproduce the issue and can confirm it is not present in 2.9 dashboard

[mmartin24]

@mmartin24 can you confirm how you created the two git repos? it would be expected that the git repo is created in the workspace that was selected at the time of creation

Edit: this can be confirmed by looking at the metadata.namespace of the gitrepo:

@richard-cox the admin does create the gitrepo on the expected workspace in both cases, here you can see how for gitrepo fleet-default-nginx, created on the workspace fleet-default, the metadata.namespace is fleet-default

For std-user-46, with the toggle pointing to fleet-default. the metadata.namespace is still fleet-default but the gitrepo displayed is the one belonging to the fleet-local workspace, (fleet-local-simple-chart)

[richard-cox]

@mmartin24 i still can't reproduce. can you try on head, and include specific steps to reproduce (for instance i created global roles and added the required group to the resource grants)? I don't think this affects much, but the gitrepo permission with just list is a bit odd (should probably include get too).

@eva-vashkevich please can you provide an update on how you reproduced and progress from yesterday?

[mmartin24]

@richard-cox, sorry for the delay.
I tried with something simpler as creating another admin user and in that case it works (although it has a delay on displaying the correct repo, in case it gives you a hint).
The best reproduction steps are the ones described in the ticket, but I can provide you a full video of our test with all the steps followed to get to this point.
Please let me know if this is ok:

Screencast.from.31-10-24.18.27.01.mov

[eva-vashkevich]

Hi @mmartin24 I am able to reproduce using steps from the ticket and will sync with Richard if needed. Right now I am still trying to figure out the cause.

[richard-cox]

Details in PR, but key bug points

• issue revolves around switching between workspaces or namespaces where the number of rows remains the same
  • hard to reproduce in namespace world given switcher isn't singular
• user irrelevant
• cause by a change of vue3 reactivity

[yonasberhe23]

Seeing correct gitrepos, clusters, and cluster groups when navigating between workspaces. Also conducted regression testing around lists.

Tested in:

• Rancher v2.10-212d8b6e92992235d791d8f2aaea8436ab4f6b77-head
• Dashboard master 99285c9

Screen.Recording.2024-11-04.at.8.59.28.PM.mov