Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.10.2] Clusters can be created/edited with broken add-on config yaml file #12466

Closed
github-actions bot opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
kind/bug kind/design QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None release-note size/3 Size Estimate 3 status/backport-candidate
Milestone

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This is a backport issue for #12323, automatically created via GitHub Actions workflow initiated by @gaktive

Original issue body:

Setup

  • Rancher version: v2.9-50aecc403a523ef45c90de73e99ec2cde182f627-head

Describe the bug
Found while testing #12067
Clusters can be created/edited with broken add-on yaml files. We need a yaml validator for the add-on config as they are now displayed in separate tabs.

To Reproduce
1- From the Clusters Management in the UI, hit Create
2- Select rke2, Input your cloud credentials, fill all the mandatory fields, then select a container network add-on
3- Navigate to the container network tab, and brake the yaml file
4- Hit create

Result
UI allows clusters to be created with broken add-on yaml files.

Expected Result
UI must have a yaml validator for the add-on config file, that displays an error message and prevents a cluster to be created if the yaml files are broken. Same behavior should be applied for the edit form.

Screen.Recording.2024-10-22.at.10.24.14.mov
@github-actions github-actions bot added kind/bug kind/design QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None release-note size/3 Size Estimate 3 status/backport-candidate labels Nov 1, 2024
@github-actions github-actions bot added this to the v2.10.1 milestone Nov 1, 2024
@gaktive gaktive modified the milestones: v2.10.1, v2.10.2 Nov 27, 2024
@mantis-toboggan-md mantis-toboggan-md changed the title [backport v2.10.1] Clusters can be created/edited with broken add-on config yaml file [backport v2.10.2] Clusters can be created/edited with broken add-on config yaml file Dec 11, 2024
@izaac
Copy link
Contributor

izaac commented Jan 14, 2025

@IsaSih could you take a look once this is ready to test? as you're the upstream reporter.

@IsaSih
Copy link
Contributor

IsaSih commented Jan 18, 2025

e2e test LGTM. Tests pass as expected, with the UI locking the Create button when the add-on config yaml file is broken on both the create and edit form.

Rancher v2.11-e9f0646414809cbaee8a1de474d8da152b522f06-head

Dashboard | master beef20e

@IsaSih IsaSih closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/design QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None release-note size/3 Size Estimate 3 status/backport-candidate
Projects
None yet
Development

No branches or pull requests

4 participants