Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unload logic from the plugin load logic #12822

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

codyrancher
Copy link
Contributor

@codyrancher codyrancher commented Dec 5, 2024

Summary

The goal is to simplify the logic while possibly improving performance.

fixes #8895

Occurred changes and/or fixed issues

Removed the logic based on this comment in the issue #8895 (comment).

Areas or cases that should be tested

With extensions installed verify the extensions behave as expected wth:

  • Logging in
  • Logging out
  • Navigating between pages

Areas which could experience regressions

See above

Screenshot/Video

No functional/visual changes should be present.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

The goal is to simplify the logic while possibly improving performance

fixes rancher#8895
@codyrancher codyrancher requested a review from aalves08 January 29, 2025 21:32
@codyrancher codyrancher marked this pull request as ready for review January 29, 2025 21:32
@aalves08 aalves08 requested review from jordojordo and nwmac and removed request for aalves08 January 30, 2025 09:24
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tested with both extension charts and ECI.

Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

I have not tested, but Jordon has.

I think we can remove the code for removePlugin as well - suggest we do this as a follow-on

@codyrancher
Copy link
Contributor Author

Code looks fine.

I have not tested, but Jordon has.

I think we can remove the code for removePlugin as well - suggest we do this as a follow-on

@nwmac that's actually what I originally did. Unfortunately, it's going to take more digging, without it our built in pkgs weren't loading translations.

@codyrancher codyrancher merged commit 76d7af2 into rancher:master Jan 30, 2025
35 of 36 checks passed
@codyrancher codyrancher deleted the remove-unload branch January 30, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard load time impacted by extension unload
3 participants