Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Settings page does not handle errors anymore from Rancher version 2.10 #13163

Open
thcdrt opened this issue Jan 20, 2025 · 2 comments
Open
Labels
JIRA kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression status/backport-candidate
Milestone

Comments

@thcdrt
Copy link

thcdrt commented Jan 20, 2025

SURE-9650

Rancher Server Setup

  • Rancher version: 2.10.1
  • Installation option (Docker install/Helm Chart):
    • Helm Chart on Kubernetes v1.28.2

User Information

  • What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)
    • If custom, define the set of permissions: Restricted Admin

Describe the bug
Hello,

We spotted that there is a regression in the error handling in Rancher dashboard settings page.
Indeed, we have a webhook preventing customers to modify some critical settings (not all).
In v2.9.7 when the webhook returned an error, the error was display in an error banner:

Image

But in version 2.10.1, the error is never displayed. Only the save button becomes red:

Image

To Reproduce

  • Install a webhook in Rancher namespace preventing settings modifications
  • Modify a setting

Result

Expected Result
The error message is displayed in a red banner in the top of the page

Screenshots
See in text

Additional context
It relates to issue #9183 but it's a bit different because in our case, it worked in previous Rancher minor version (2.9) while it never worked on the driver page side.

Thanks,
Best Regards,
Thomas

@richard-cox richard-cox transferred this issue from rancher/rancher Jan 20, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 20, 2025
@richard-cox richard-cox added this to the v2.11.0 milestone Jan 20, 2025
@cnotv
Copy link
Member

cnotv commented Jan 22, 2025

The 2 issues are completely different. This one is related to the architecture changes in the major JS framework update.

@cnotv
Copy link
Member

cnotv commented Jan 22, 2025

I cannot generate a network response different from 200 when I use any type of value, which makes me think there's no validation at all from the server side.
Could you please point out a case and the response in the payload of the request in the network panel?

Sorry I re-read the issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JIRA kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression status/backport-candidate
Projects
None yet
Development

No branches or pull requests

4 participants