From 294f08b1273f839910e31c5efdda2c216bb0197e Mon Sep 17 00:00:00 2001 From: Andrea Trendafilov Date: Wed, 8 Nov 2023 12:12:58 +0200 Subject: [PATCH 1/3] Fix-issue-939 Upgrade default Node.js version to 16 Resolves a warning about Node.js 12 in the build action by upgrading the default Node.js version to 16 in the Ubuntu image. Changes to be committed: modified: .github/workflows/pull-request.yaml --- .github/workflows/pull-request.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index 734e8c433d..edefc62aa2 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -12,6 +12,9 @@ jobs: CI_TOOLS_URL: https://github.com/samuelattwood/partner-charts-ci/releases/latest/download/partner-charts-ci-linux-amd64 steps: + - uses: actions/setup-node@v2 + with: + node-version: '16.x' - uses: actions/checkout@v2 with: fetch-depth: 0 @@ -36,5 +39,5 @@ jobs: run: git rebase origin/main-source - name: Validate - if: "!contains(github.event.pull_request.title, '[modified charts]')" + if: '!contains(github.event.pull_request.title, "[modified charts]")' run: partner-charts-ci validate From 356125852d734d47491a17f70c14f5c28ee1df5b Mon Sep 17 00:00:00 2001 From: Andrea Trendafilov Date: Wed, 8 Nov 2023 18:08:33 +0200 Subject: [PATCH 2/3] fix typo --- .github/workflows/pull-request.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index edefc62aa2..f9ed87f06d 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -39,5 +39,5 @@ jobs: run: git rebase origin/main-source - name: Validate - if: '!contains(github.event.pull_request.title, "[modified charts]")' + if: "!contains(github.event.pull_request.title, '[modified charts]')" run: partner-charts-ci validate From b7016b88940c2dd05388e2fa0ed6845907f4dd51 Mon Sep 17 00:00:00 2001 From: Andrea Trendafilov Date: Thu, 9 Nov 2023 15:38:11 +0200 Subject: [PATCH 3/3] edit requested by @recena --- .github/workflows/pull-request.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index f9ed87f06d..8e705e59ac 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -12,10 +12,7 @@ jobs: CI_TOOLS_URL: https://github.com/samuelattwood/partner-charts-ci/releases/latest/download/partner-charts-ci-linux-amd64 steps: - - uses: actions/setup-node@v2 - with: - node-version: '16.x' - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0