We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rancherd version: v0.0.1-alpha13
v0.0.1-alpha13
To Reproduce
Init a cluster with the following config:
# cat /etc/rancher/rancherd/config.yaml role: cluster-init token: somethingrandom kubernetesVersion: v1.21.8+k3s1 rancherVersion: stable registries: mirrors: docker.io: endpoint: - "http://192.168.2.106:5000" k8s.gcr.io: endpoint: - "http://192.168.2.106:5001" quay.io: endpoint: - "http://192.168.2.106:5002"
The generated registries.yaml file has content:
registries.yaml
# cat /etc/rancher/k3s/registries.yaml Auths: null Configs: null Mirrors: docker.io: Endpoints: null Rewrites: null k8s.gcr.io: Endpoints: null Rewrites: null quay.io: Endpoints: null Rewrites: null
If I changed the field endpoint to endpoints in the /etc/rancher/rancherd/config.yaml file, the generated file will be:
endpoint
endpoints
/etc/rancher/rancherd/config.yaml
# cat /etc/rancher/k3s/registries.yaml Auths: null Configs: null Mirrors: docker.io: Endpoints: - http://192.168.2.106:5000 Rewrites: null k8s.gcr.io: Endpoints: - http://192.168.2.106:5001 Rewrites: null quay.io: Endpoints: - http://192.168.2.106:5002 Rewrites: null
This seems to be correct but k3s only accepts the key endpoint, not endpoints https://rancher.com/docs/k3s/latest/en/installation/private-registry/#mirrors
Some investigation
The Endpoints field has no json field tag: https://github.com/rancher/wharfie/blob/efd07c927031e0b324f5ce56211eea0c4a13ca06/pkg/registries/types.go#L9
Endpoints
json
And package "sigs.k8s.io/yaml" is used to marshal the registry, which uses json.marshal and converts the result to yaml
"sigs.k8s.io/yaml"
json.marshal
rancherd/pkg/registry/registry.go
Line 18 in 7e9f0fe
This might be the reason the generated file has key endpoint"s".
The text was updated successfully, but these errors were encountered:
Consume go-tpm in place of tpm in rancherd/os2
6d94498
Part of rancher#20. Will allow later on to set an emulated device. Signed-off-by: Ettore Di Giacinto <[email protected]>
No branches or pull requests
rancherd version:
v0.0.1-alpha13
To Reproduce
Init a cluster with the following config:
The generated
registries.yaml
file has content:If I changed the field
endpoint
toendpoints
in the/etc/rancher/rancherd/config.yaml
file, the generated file will be:This seems to be correct but k3s only accepts the key
endpoint
, notendpoints
https://rancher.com/docs/k3s/latest/en/installation/private-registry/#mirrors
Some investigation
The
Endpoints
field has nojson
field tag: https://github.com/rancher/wharfie/blob/efd07c927031e0b324f5ce56211eea0c4a13ca06/pkg/registries/types.go#L9And package
"sigs.k8s.io/yaml"
is used to marshal the registry, which usesjson.marshal
and converts the result to yamlrancherd/pkg/registry/registry.go
Line 18 in 7e9f0fe
This might be the reason the generated file has key endpoint"s".
The text was updated successfully, but these errors were encountered: