Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Unused variable in JNI/Java binding for readParquet #12031

Open
ttnghia opened this issue Oct 31, 2022 · 3 comments
Open

[FEA] Unused variable in JNI/Java binding for readParquet #12031

ttnghia opened this issue Oct 31, 2022 · 3 comments
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request Java Affects Java cuDF API.
Milestone
Parquet continuou...

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Oct 31, 2022 •
edited
Loading

This is not a complete FEA but is closed to it. Currently, from Java we pass in a boolean variable binaryToString to JNI readParquet but it is unused after merging #11524. This variable may be used in the future thus we didn't remove it.

This issue is to track that unused variable.
@ttnghia ttnghia added feature request New feature or request Needs Triage Need team to review and classify labels Oct 31, 2022
@ttnghia
Copy link
Contributor Author

ttnghia commented Oct 31, 2022

CC @sameerz @revans2.

@ttnghia ttnghia added 0 - Backlog In queue waiting for assignment Java Affects Java cuDF API. labels Oct 31, 2022
@GregoryKimball GregoryKimball removed the Needs Triage Need team to review and classify label Nov 5, 2022
@GregoryKimball
Copy link
Contributor

@revans2 should we remove the variable now?

@revans2
Copy link
Contributor

revans2 commented Feb 20, 2024

We can remove it whenever. It is just a question of finding time to do the code cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
Milestone
Parquet continuous improvement
Development

No branches or pull requests
3 participants
@revans2 @ttnghia @GregoryKimball