Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Parquet reader: replace skip_rows / num_rows with start_row / end_row #14465

Open
nvdbaranec opened this issue Nov 21, 2023 · 0 comments
Open
Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@nvdbaranec
Copy link
Contributor

Our external interface to the parquet reader allows the user to specify skip_rows / num_rows parameters when calling it. Internally, we use the same values. But it is a very unwieldy way to think about things. I think it would be easier to immediately convert those values to start_row and end_row and use that everywhere. It's a nontrivial amount of work to do this without causing bugs but I think the code would be more natural (in the std::algorithms / iterator sense of the word).

@nvdbaranec nvdbaranec added feature request New feature or request Needs Triage Need team to review and classify cuIO cuIO issue labels Nov 21, 2023
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Dec 14, 2023
@GregoryKimball GregoryKimball moved this to To be revisited in libcudf Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: To be revisited
Development

No branches or pull requests

2 participants