-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook to lint CODEOWNERS files #61
Comments
+1, I support these choices of defaults and have nothing to add. |
I've modified #60 to enforce selective ordering of these files. |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this issue
Jan 29, 2025
Issue: rapidsai/pre-commit-hooks#61 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #17840
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/cugraph
that referenced
this issue
Jan 29, 2025
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/cuml
that referenced
this issue
Jan 29, 2025
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/raft
that referenced
this issue
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The purpose of this hook is to ensure consistent review strategies across RAPIDS so that different projects make the most effective use of their teams for reviews. Here are some standard things we could enforce.
CI codeowners:
Packaging codeowners:
C++ codeowners:
Python codeowners:
CMake codeowners:
Note that order is important and these entries should come below the C++/Python entries because CODEOWNERS is order-dependent and we probably don't want to make Python or C++ devs review these files. We may need to first explicitly assign the appropriate subsets of these files to the corresponding groups before we can assign them here so that we don't add in the wrong groups.
The text was updated successfully, but these errors were encountered: