Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to lint CODEOWNERS files #61

Closed
vyasr opened this issue Jan 14, 2025 · 2 comments · Fixed by #60
Closed

Add hook to lint CODEOWNERS files #61

vyasr opened this issue Jan 14, 2025 · 2 comments · Fixed by #60

Comments

@vyasr
Copy link
Contributor

vyasr commented Jan 14, 2025

The purpose of this hook is to ensure consistent review strategies across RAPIDS so that different projects make the most effective use of their teams for reviews. Here are some standard things we could enforce.

CI codeowners:

  • /.github/
  • /ci/

Packaging codeowners:

  • /conda/
  • dependencies.yaml
  • /build.sh
  • pyproject.toml
  • /.pre-commit-config.yaml
  • /.devcontainer/

C++ codeowners:

  • cpp/

Python codeowners:

  • python/
  • notebooks/ # In repos this exists

CMake codeowners:
Note that order is important and these entries should come below the C++/Python entries because CODEOWNERS is order-dependent and we probably don't want to make Python or C++ devs review these files. We may need to first explicitly assign the appropriate subsets of these files to the corresponding groups before we can assign them here so that we don't add in the wrong groups.

  • CMakeLists.txt
  • **/cmake/
  • *.cmake
@jameslamb
Copy link
Member

+1, I support these choices of defaults and have nothing to add.

@KyleFromNVIDIA
Copy link
Contributor

I've modified #60 to enforce selective ordering of these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants