Artwork

[dleggo]

Some possible artwork. I can change anything if needed. I would've made a PR for this, but I'm not quite sure where they should go. Maybe in WindowServer, or AppKit?

An example of how those buttons look on a window.

[mszoek]

Very nice, thank you!

[mszoek]

@dleggo can you please make sure all the pngs have the same spacing top, bottom, left, and right of the images? I think the yellow button is slightly lower than the others.

[dleggo]

Here is the image with a line at a fixed height.

They all seem to be at the same height, unless if I am perceiving something incorrectly?
I also checked my images and they seemed to be lined up.

[mszoek]

Thanks. Might just be an illusion on my screen then. It seemed 1-2px lower at the top of the yellow circle than the red and green ones.

[mszoek]

For the record, here is what the icons look like in WindowServer :)

[dleggo]

Thanks! Is it possible to render the buttons with anti-aliasing? Does WindowServer support that yet? The maximize button seems to render with the arrows a bit small/deformed, which I never noticed during my tests, but maybe that is an anti-aliasing thing...? If needed, I can change anything to try make them render better too!

[mszoek]

It would be best to make them render properly at this size. I can implement AA eventually but I'm trying to keep any compute in the rendering loop very minimal since it is all software (no GPU accel) on the framebuffer backend.

[dleggo]

Unfortunately I can not reproduce this issue... When I scale the png to 16x16 (without anti-aliasing) I get.

How are the buttons being rendered? That might help me to find what I need to change. I could apply a blur effect to simulate anti-aliasing at small sizes... If needed I can also supply the svgs too.

[mszoek]

Hmm. The rendering just uncompresses the PNG and draws the bitmap. It is probably the scaling algorithm that causes this. I'll take a look. Can you try giving me 16x16 and 32x32 versions that looks ok to you? It'll be a good test.

[dleggo]

Both scaled in GIMP with no interpolation.

16x16

32x32

Thanks for all your work on this!