-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keen slider disabling double tap/pinch to zoom in/out? #237
Comments
Hey @rizabek-mukanov yes, this is intentional for the default slider. |
@rcbyr thanks for your work. What is the reason behind tweaking touch-actions by default? Is this a mere usability thing? |
@rcbyr I tried your example in both Firefox for Android and Brave for Android and I couldn't use pinch zoom in either. This is the one thing that's missing for me in this library. The only slider libraries I've found pinch zoom to work with are Swiper and Glider.js (but this one uses native scrolling). I'd love to see this work in Keen-Slider too. |
I made a PR for this at #312, if it's helpful. |
i have modal with images where every image is keen slider slide. apparently double tap and pinch are not working to zoom.
is it intentionally done by lib? i was thinking keen slider itself handle slide events and thats why it disables some other events
The text was updated successfully, but these errors were encountered: