RDKBNETWOR-21 : Integrating CcspMisc changes to DHCPManager #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Integrating CcspMisc changes to DHCPManager required for Wanmanager Integration Test Procedure: DHCPManager should run without any new regressions Risks: Low Priority: Minor Signed-off-by:[email protected]
|
bprasa339 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kul2241
reviewed
Jan 22, 2025
|
|
||
| if DHCP_MANAGER_ENABLE | ||
| wanmanager_LDADD += -lCcspDhcpMgr_Dhcpv6Client -lCcspDhcpMgr_Dhcpv4Client |
There was a problem hiding this comment.
Wan Manager does not need to talk with dhcp manager client library, so line 37 is not required.
kul2241
reviewed
Jan 22, 2025
|
|
||
| if DHCP_MANAGER_ENABLE |
There was a problem hiding this comment.
we don't need to create new build flag for it, we could use the existing FEATURE_RDKB_DHCP_MANAGER build flags.
kul2241
reviewed
Jan 22, 2025
| @@ -101,6 +101,15 @@ AC_ARG_ENABLE([wanunificationsupport], | |||
| [echo "mapt unification is disabled"]) | |||
| AM_CONDITIONAL(WAN_UNIFICATION_ENABLED, test "x$WAN_UNIFICATION_SUPPORT_ENABLED" = xtrue) | |||
|
|
|||
| AC_ARG_ENABLE([dhcp_manager], | |||
There was a problem hiding this comment.
if you are going to use FEATURE_RDKB_DHCP_MANAGER , then we could not need this code changes.
kul2241
requested changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Integrating CcspMisc changes to DHCPManager required for Wanmanager Integration Test Procedure: DHCPManager should run without any new regressions Risks: Low
Priority: Minor
Signed-off-by:[email protected]