Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLPO encountered division by zero #82

Closed
KrishaKumaleManandhar opened this issue Dec 25, 2024 · 1 comment · Fixed by #83
Closed

LLPO encountered division by zero #82

KrishaKumaleManandhar opened this issue Dec 25, 2024 · 1 comment · Fixed by #83
Assignees
@KrishaKumaleManandhar

Comments

@KrishaKumaleManandhar
Copy link

An exception of Floating Error where ECR_after_LLPO was set to 0 instead of LLPO in causing/model.py is leading to all ECRs to zero

Screenshot from 2024-12-16 13-05-26
@KrishaKumaleManandhar KrishaKumaleManandhar self-assigned this Dec 25, 2024
@KrishaKumaleManandhar KrishaKumaleManandhar linked a pull request Dec 25, 2024 that will close this issue
applying npfloat128 #83
Merged
@Holger-Bartel
Copy link
Contributor

@KrishaKumaleManandhar @bbkrr and that is a great find indeed (not new, we saw that earlier). In case of a numeric error we want to set LLPO to zero NOT ECR.
Anyway, now that you have the new LLPO proxy we should DELETE that code. May this was the error we have been looking for all the time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrishaKumaleManandhar KrishaKumaleManandhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

applying npfloat128 realrate/Causing
2 participants
@Holger-Bartel @KrishaKumaleManandhar