Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier customization of Drawer close button #271

Open
steppy452 opened this issue Dec 19, 2024 · 0 comments
Open

Allow easier customization of Drawer close button #271

steppy452 opened this issue Dec 19, 2024 · 0 comments

Comments

@steppy452
Copy link
Contributor

steppy452 commented Dec 19, 2024

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Currently, the close button for Drawer (possibly also Dialog?) is an x in the header component. And in order to customize, we have to create a new custom header component and replicate close functionality.

Expected behavior

Drawer component can take in a closeButtonIcon which will allow us to override the default x

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Easier customization to match unique styles

Environment


Libs:
- react version: X.Y.Z
- reablocks version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant