Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who wants to help? #1

Open
thibautjombart opened this issue Oct 14, 2019 · 19 comments
Open

Who wants to help? #1

thibautjombart opened this issue Oct 14, 2019 · 19 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@thibautjombart
Copy link
Contributor

This issue is merely here for people to manifest their interest in this project. We can't offer money, but gratitude aplenty - and hopefully some recognition from people in the field :)

Reply here if interested.

@thibautjombart thibautjombart added help wanted Extra attention is needed question Further information is requested labels Oct 14, 2019
@niyukuri
Copy link

Great initiative, will be happy to join the team!

@PaulC91
Copy link
Collaborator

PaulC91 commented Oct 14, 2019

Hi all. We're doing a lot of shiny stuff @epicentre-msf and we'd be happy to help here. I've built an app with some similar features before so it shouldn't take too long! Cheers.

@thibautjombart
Copy link
Contributor Author

Hi all. We're doing a lot of shiny stuff @epicentre-msf and we'd be happy to help here. I've built an app with some similar features before so it shouldn't take too long! Cheers.

This would be awesome. If you have access to the instrastructure, you can check:
pCloudDrive/Shared/evd_eoc_goma/analysis_infrastructure/ad_hoc_analyses/report_sources/compare_data/

I will upload the Rmd here. Cannot share full infrastructure or outputs on github for data sharing issues.

@jrcpulliam
Copy link
Member

🙋

@PaulC91
Copy link
Collaborator

PaulC91 commented Oct 14, 2019

Yes I have pcloud access so I'll have a look now.

@thibautjombart
Copy link
Contributor Author

I will try to share a full data infrastructure with some toy datasets later today.

@thibautjombart
Copy link
Contributor Author

I will try to share a full data infrastructure with some toy datasets later today.

There we go:
https://github.com/reconhub/report_factories_templates

Let's use this as a base for the shiny app?

@marialma
Copy link

would absolutely love to help!

@PaulC91
Copy link
Collaborator

PaulC91 commented Oct 14, 2019

Hi all.

I made a start to this today setting the app up as an R package using the golem framework. Let me know if you want me to PR my fork into this repo and we can all collaborate from there?

Having the app as a package would allow users to easily run the app locally by installing the package and running the run_app() function.

Let me know your thoughts!

@nistara
Copy link
Member

nistara commented Oct 15, 2019

I'd love to help!

@cmaronga
Copy link

Hey, I would love to offer my contribution. I have done a few shiny dashboards to aid data management for a large multi-sites cohort study, hope my experience would help.

@thibautjombart
Copy link
Contributor Author

Great to see a team assemble! I have created a #datacomparator channel on the RECON slack. Added Juliet and Nistara, don't know other user names, but just join - it's public.

@frequena
Copy link

Count on me!

@thibautjombart
Copy link
Contributor Author

You people rock!! :) I am tagging @amygimma who's doing dev with the analytics cell to coordinate the project. We'll probably try to have a TC very soon - tommorow afternoon ideally. Will post info here.

@thibautjombart
Copy link
Contributor Author

Hi all.

I made a start to this today setting the app up as an R package using the golem framework. Let me know if you want me to PR my fork into this repo and we can all collaborate from there?

Having the app as a package would allow users to easily run the app locally by installing the package and running the run_app() function.

Let me know your thoughts!

Seen a presentation on golem at the last UseR conf. A lot went over my head, but it seemed cool. Easier deployment is definitely a big plus. PR welcome too. If we TC tomorrow it would be great to hear / see where things are at.

@PaulC91
Copy link
Collaborator

PaulC91 commented Oct 15, 2019

Seen a presentation on golem at the last UseR conf. A lot went over my head, but it seemed cool. Easier deployment is definitely a big plus. PR welcome too. If we TC tomorrow it would be great to hear / see where things are at.

Made some more progress today. You should be able to run what I have with

remotes::install_github("paulc91/datacomparator")

datacomparator::run_app()

I'll make a PR tomorrow! cheers.

@amygimma
Copy link
Contributor

Hi everyone!

Glad to see there's solid interest in this! Thanks @PaulC91 for getting this started, let's keep building on your work.

I've created a doodle poll for availability tomorrow - I'm thinking it won't be more than 20 - 30 minutes. I'll take a look at the poll this evening and confirm the time. We'll use Recon's Whereby account to meet.

Feel free to join us on slack as well!

Agenda

  • Intros to project & people
  • Review of existing code
  • Create action items
  • Assign items

Hope to see you tomorrow!

@amygimma
Copy link
Contributor

Hey everyone, let's go with tomorrow 14:00 (CAT / GMT +2).

https://whereby.com/reconhub

@amygimma
Copy link
Contributor

Meeting Notes and Follow up:

Paul got us off to a great start using the golem package, and has implemented the basic functionality of the app.

Outstanding Issues and Tasks:

  • Update the README, @nistara will lead
  • Implement basic error handling (@paul Campbell)
  • Make date field optional
  • Make number of days to filter optional (default is to include all rows)
  • Set up a server to host the web based version of the app (@paul Campbell)
  • User testing: try different datasets in an effort to break the app to look for more issues (I added dates to the cars dataset, which breaks the app). When adding issues, include original data and full error message/stack traces (as available)
  • User testing: Document difficulties in installing the datacomparator app and dependencies as github issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

9 participants