Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailer README doesn't include .env instructions #19

Open
j-norwood-young opened this issue Aug 6, 2019 · 3 comments
Open

Mailer README doesn't include .env instructions #19

j-norwood-young opened this issue Aug 6, 2019 · 3 comments

Comments

@j-norwood-young
Copy link

The Mailer documentation is self-standing and complete except that it doesn't include the instructions for the .env file.
@rootpd
Copy link
Member

rootpd commented Aug 9, 2019

Aren't the comments within .env.example explanatory enough? We didn't want to duplicate that information also to README, it would get inconsistent over time.

@rootpd
Copy link
Member

rootpd commented Aug 9, 2019

Maybe we could add the information about .env.example into the README? Would that help you when you read it before?

(maybe somewhere right at the top of readme and everywhere .env is mentioned)

@j-norwood-young
Copy link
Author

Yeah, that would help tremendously. Just when working through the installation instructions, I hit the problem. It wasn't difficult to solve, it just felt like the instructions were incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j-norwood-young @rootpd