Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph view snapshots are broken #8940

Closed
teh-cmc opened this issue Feb 5, 2025 · 1 comment · Fixed by #8941
Closed

Graph view snapshots are broken #8940

teh-cmc opened this issue Feb 5, 2025 · 1 comment · Fixed by #8941
Assignees
@Wumpf
Labels
🪳 bug Something isn't working feat-graph-view Everything related to the graph view 📺 re_viewer affects re_viewer itself ⛴ release Related to shipping or publishing 🔨 testing testing and benchmarks
Milestone
0.22 - Entity fil...

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 5, 2025

main is not complaining for no reasons, this is what you see if you try to update the graph view snapshots right now:
Image
@teh-cmc teh-cmc added feat-graph-view Everything related to the graph view ⛴ release Related to shipping or publishing 📺 re_viewer affects re_viewer itself 🔨 testing testing and benchmarks 🪳 bug Something isn't working labels Feb 5, 2025
@Wumpf
Copy link
Member

Wumpf commented Feb 5, 2025

main started complaining by now, phew!
https://github.com/rerun-io/rerun/actions/runs/13161352407/job/36730623545

Image did not match snapshot. Diff: 115, "/Users/runner/work/rerun/rerun/crates/viewer/re_view_graph/tests/snapshots/coincident_nodes.diff.png".

@Wumpf Wumpf self-assigned this Feb 5, 2025
@Wumpf Wumpf mentioned this issue Feb 5, 2025
Merged
Wumpf added a commit that referenced this issue Feb 5, 2025
@Wumpf
Fix graph view test (#8941)
b849a91 
* Fixes #8940

By using test-log_entity API with user facing archetypes so proper
indicators etc. are set.

This broke in #8927 since this PR
makes it so that indicator based visualizer filtering is active -
curiously without that we'd just use all the available visualizers which
in our tests _so far_ worked out fine.
Still totally unclear why we intermittently didn't see this breaking (it
luckily breaks main right now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working feat-graph-view Everything related to the graph view 📺 re_viewer affects re_viewer itself ⛴ release Related to shipping or publishing 🔨 testing testing and benchmarks
Projects
None yet
Milestone
0.22 - Entity filtering and partial u...
Development

Successfully merging a pull request may close this issue.

Fix graph view test rerun-io/rerun
2 participants
@Wumpf @teh-cmc