From 3c1c478ecba842bb063226712520285c461c2eae Mon Sep 17 00:00:00 2001
From: fxliang <fx.liang@outlook.com>
Date: Sun, 18 Aug 2024 05:24:19 +0800
Subject: [PATCH] chore: more detail log info when key_binder/bindings parsing
 errors happen (#922)

---
 src/rime/gear/key_binder.cc | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/rime/gear/key_binder.cc b/src/rime/gear/key_binder.cc
index de37366954..f1e67c905e 100644
--- a/src/rime/gear/key_binder.cc
+++ b/src/rime/gear/key_binder.cc
@@ -178,7 +178,9 @@ void KeyBindings::LoadBindings(const an<ConfigList>& bindings) {
     }
     KeyEvent key;
     if (!key.Parse(pattern->str())) {
-      LOG(WARNING) << "invalid key binding #" << i << ".";
+      LOG(WARNING) << "invalid key binding #" << i
+                   << ", with invalid accept pattern: " << pattern->str()
+                   << ".";
       continue;
     }
     if (auto target = map->GetValue("send")) {
@@ -186,12 +188,15 @@ void KeyBindings::LoadBindings(const an<ConfigList>& bindings) {
       if (key.Parse(target->str())) {
         binding.target.push_back(std::move(key));
       } else {
-        LOG(WARNING) << "invalid key binding #" << i << ".";
+        LOG(WARNING) << "invalid key binding #" << i
+                     << ", with invalid send pattern: " << target->str() << ".";
         continue;
       }
     } else if (auto target = map->GetValue("send_sequence")) {
       if (!binding.target.Parse(target->str())) {
-        LOG(WARNING) << "invalid key sequence #" << i << ".";
+        LOG(WARNING) << "invalid key sequence #" << i
+                     << ", with invalid send_sequence pattern: "
+                     << target->str() << ".";
         continue;
       }
     } else if (auto option = map->GetValue("toggle")) {
@@ -211,7 +216,9 @@ void KeyBindings::LoadBindings(const an<ConfigList>& bindings) {
         select_schema(engine, schema->str());
       };
     } else {
-      LOG(WARNING) << "invalid key binding #" << i << ".";
+      LOG(WARNING) << "invalid key binding #" << i
+                   << ", accept: " << pattern->str()
+                   << ", when: " << whence->str() << ".";
       continue;
     }
     Bind(key, binding);