Codify Save/Restore Frame Layout #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kito-cheng I know you did the GCC implementation, hopefully you feel this wording is good enough to allow some flexibility in implementation, while still ensuring compilers can emit the right CFI information? |
lenary
force-pushed
the
pr/save-restore-layout
branch
from
790e21a to
35aff36
Compare
kito-cheng
reviewed
Jan 6, 2025
lenary
force-pushed
the
pr/save-restore-layout
branch
from
35aff36 to
07462b9
Compare
kito-cheng
approved these changes
Jan 16, 2025
These layouts need to be compatible between what the compiler expects when emitting CFI information, and what the library actually implements, so we write a bit more detail about how these should work to ensure that compatibility. Fixes riscv-non-isa#35 Signed-off-by: Sam Elliott <[email protected]>
lenary
force-pushed
the
pr/save-restore-layout
branch
from
07462b9 to
f0402aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These layouts need to be compatible between what the compiler expects when emitting CFI information, and what the library actually implements, so we write a bit more detail about how these should work to ensure that compatibility.
Fixes #35