Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 4 #23

Open
vharish opened this issue Oct 23, 2018 · 3 comments
Open

Support Symfony 4 #23

vharish opened this issue Oct 23, 2018 · 3 comments

Comments

@vharish
Copy link

vharish commented Oct 23, 2018

Hi,

It's clear from the composer file that the supported version of Symfony is 3.3. I would like to know if there are any plans to update the library to support Symfony 4.

Thanks.

@rjanot
Copy link
Owner

rjanot commented Oct 23, 2018

Hi, thanks for the question.

Honnestly, it's not in the pipe on my side.
But If you upgrade requirements, please, do a PR, I will be really happy to merge it.

Rémi

@vharish
Copy link
Author

vharish commented Oct 23, 2018

@rjanot Thanks for the reply. I'll see what I can do.

@vharish
Copy link
Author

vharish commented Oct 25, 2018

@rjanot Simply updating the version constraint to allow symfony framework version 4.0 has worked. However, I haven't run any test cases and I can't say for sure that no other changes are required, although I believe everything works fine as it is.

For our use case though, the above mentioned change has worked. I've forked the repo and made the changes. I am not going to create a PR for the reasons stated above.

Thanks,
Harish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants