Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerMoveEvent problem #919

Closed
ygtdmn opened this issue Oct 26, 2016 · 11 comments
Closed

PlayerMoveEvent problem #919

ygtdmn opened this issue Oct 26, 2016 · 11 comments

Comments

@ygtdmn
Copy link

ygtdmn commented Oct 26, 2016

/usb version:
16:36:48 INFO: Name: uSkyBlock
16:36:48 INFO: Version: 2.7.3-alpha7
16:36:48 INFO: Description: Ultimate SkyBlock v2.7.3-alpha7-367c72-441
16:36:48 INFO: Language: tr (tr)
16:36:48 INFO: State: d=160, r=80, i=4,752, p=4,784, n=false, awe=false
16:36:48 INFO: Server: CraftBukkit git-TacoSpigot-"c80c1e5" (MC: 1.8.8)
16:36:48 INFO: State: online=true, bungee=true

16:36:48 INFO: Vault 1.5.6-b49 (ENABLED)
16:36:48 INFO: WorldEdit 6.1.3;7a097ca (ENABLED)
16:36:48 INFO: WorldGuard 6.1 (ENABLED)
16:36:48 INFO: Multiverse-Core 2.5-b717 (ENABLED)
16:36:48 INFO: Multiverse-NetherPortals maven-version-number (WRONG-VERSION)

[16:35:41 ERROR]: Could not pass event PlayerMoveEvent to uSkyBlock v2.7.3-alpha7
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[patched.jar:git-TacoSpigot-"c80c1e5"]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[patched.jar:git-TacoSpigot-"c80c1e5"]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched.jar:git-TacoSpigot-"c80c1e5"]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501) [patched.jar:git-TacoSpigot-"c80c1e5"]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:486) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:273) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.PacketPlayInFlying.a(SourceFile:126) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.PacketPlayInFlying$PacketPlayInPosition.a(SourceFile:57) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [patched.jar:git-TacoSpigot-"c80c1e5"]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_77]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_77]
at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:774) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:379) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:713) [patched.jar:git-TacoSpigot-"c80c1e5"]
at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:616) [patched.jar:git-TacoSpigot-"c80c1e5"]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_77]
Caused by: java.lang.NullPointerException

I dont know why is this happening but i saw it in my console and i wanted to write that.

@dutchy1001
Copy link
Contributor

Is it an error that keeps poppin up or just once? If once then disregard this as a glitch.
You also have a wrong depended plugin for the MV-NetherPortals ((WRONG-VERSION) is indicating this), that could also cause an error, not saying this is related but it could.

@ygtdmn
Copy link
Author

ygtdmn commented Oct 28, 2016

I edited MV-NetherPortals plugin for that issue Multiverse/Multiverse-NetherPortals#118

I will make more test to find out why this error happening.

@ygtdmn ygtdmn changed the title NullPointer EventException PlayerMoveEvent problem Nov 6, 2016
@ygtdmn
Copy link
Author

ygtdmn commented Nov 6, 2016

Problem is continuing. Today i had 500 MB logs full of Nullpointerexception.

500 MB logs (compressed 3mb, i can open with Notepad++):
https://www.dropbox.com/s/04hz465xz56g4w2/latest.log.tar.gz?dl=0

Spammed Exception:
http://pastebin.com/x6hsWhRs

And it is not about Nether Portals.

@ygtdmn
Copy link
Author

ygtdmn commented Nov 13, 2016

I couldnt find the reason but im tired of 1GB logs everyday. I cant check my logs because of this error.

@dutchy1001
Copy link
Contributor

I'm sorry this is happening but I would recommend to add Multivers-Portals and use an original Multivers-NetherPortals.
I hear you say it's that that is not the issue but if you don't try you will never know. Send me a log were those plugins are added with the errors showing then we can rule out that cause.
As long you don't use the recommended dependencies we cannot guarantee the correct working of the plugin.
As nobody else is complaining that this issue in this extend is on their servers (and believe me they would complain) I'm almost sure that the cause is not uSkyblock but caused due to an other plugin.

You could use the next alpha build here and see if that makes a differance.

I never have used TacoSpigot which also could be a cause, try PaperSpigot or even normal Spigot to rule those versions out too.

@rlf
Copy link
Owner

rlf commented Nov 15, 2016

@uniodex this (and most of the other issues you have been experiencing), is caused by you using offline mode, and having errorneous entries in the name2uuid.yml file.

A work-around could be, to somehow disable the use of our player-database (i.e. making all calls go directly to the Bukkit.getPlayer), this will most likely remove the NullPointerExceptions, but most certainly lead to performance issues.

@ygtdmn
Copy link
Author

ygtdmn commented Nov 16, 2016

@rlf you should add a warning in landing page like: "Dont use this plugin if your server is offline mode. When you notice a bug to us we will always excuse it." And i wouldnt open my server with that plugin.

@dutchy1001
Copy link
Contributor

I don't think we have to state that offline servers "could" have issue's, any server, offline or online, can have issue's all depending on many other things. There are plenty offline servers using this without any issue. If this was the case you wouldn't be the only one complaining.
Like I said in one of my previous messages, have you done any of those suggestions to see if that helped?

@ygtdmn
Copy link
Author

ygtdmn commented Nov 16, 2016

Yes. Im using PaperSpigot, im using the original MVNetherPortals but it is not solved. But i didnt try changing my online-mode=false part to online-mode=true.

As @rlf said that this is about using offline mode. I dont understand why this error about using offline mode.

@BlackBeltPanda
Copy link
Collaborator

Happening for me now with an online-mode server: #934

@rlf
Copy link
Owner

rlf commented Nov 21, 2016

For performance reasons we tried to introduce a caching of the player-name-2-uuids.
In the first "version" this was made as a yml-file, unfortunately, the libraries for accessing yml files are not thread-safe, meaning this is a shitty platform for that sort of data.

The very-short-term-solution is to delete the name2uuid.yml file and reload (/usb reload).
The short-term-solution is to introduce a way to circumvent the yml-file (i.e. asking Bukkit directly, this will introduce a performance penalty).
The long-term-solution is to move the "database" into a database-format (SQLite and/or MySQL).

I have had a lot of other priorities, and have done next to no development on uSkyBlock for a couple of months - so unfortunately - there is no ETA on this issue. Perhaps I will find some time during Christmas... perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants