Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific Book Won't Download #1116

Closed
jacobfiala opened this issue Jan 13, 2025 · 15 comments
Closed

Specific Book Won't Download #1116

jacobfiala opened this issue Jan 13, 2025 · 15 comments
Labels
bug Something isn't working

Comments

@jacobfiala
Copy link

Describe the bug
A clear and concise description of what the bug is.

This specific book won't download, but no issues with any other books
https://www.audible.com/pd/The-New-Huey-P-Newton-Reader-Audiobook/B07WSRNDXP

Error Pop-Up:
An error occurred while trying to process this book.
Title: The New Huey P. Newton Reader
ID: B07WSRNDXP
Author: Huey P. Newton, David Hilliard - editor,
Donald...
Narr: Ryan Vincent Anderson, Larry Herron, Joniece Ab...

  • ABORT: Stop processing books.
  • RETRY: retry this book later. Just skip it for now.
    Continue processing books. (Will try this book again later.)
  • IGNORE: Permanently ignore this book. Continue processing books. (Will not try this book again later.)
    See Settings to avoid this box in the future.

I've retried several times, but the error happens immediately upon starting the download.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Liberate'
  2. Click on 'Liberate Visible Books: 1'
  3. Almost Immediately, the error pops up

I've tried changing around some of the settings under "Audio File Settings", but this didn't change anything.

Expected behavior
A clear and concise description of what you expected to happen.

For other books, they all download just fine.

Screenshot 2025-01-13 at 5 11 56 PM

Platform
macOS 15.2; Macbook Air M1

Log Files
Attach your Libation log file here.

_Log202501.zip

@jacobfiala jacobfiala added the bug Something isn't working label Jan 13, 2025
@rmcrackan
Copy link
Owner

Sorry about this. Thank you very much for your log. I fixed a bit of code around this issue but I haven't fully released the change yet. Can you please try this pre-release and let me know whether it fixes your issue -- https://github.com/rmcrackan/Libation/releases/tag/v11.6.4

@jacobfiala
Copy link
Author

This did not fix the issue, and furthermore, I now get this error upon opening the app and my library is no longer listed on the left.
image

Scanning the library does not return the list either. But the "liberate" command still works for placing the undownloaded ones into the queue.

image

But of course, they are still not downloading

@rmcrackan
Copy link
Owner

Can you attach your new log?

@jacobfiala
Copy link
Author

_Log202501.zip

@jacobfiala
Copy link
Author

Thank you so much for your help by the way! <3

@rmcrackan
Copy link
Owner

Thank you very much for the log.

There are a few parts here which you might want to play with. I'd try these tests on one book at a time, one settings-change at a time to see what's breaking. If other things work the maybe we can isolate what combination is breaking on your system.

  • it might be something about the mp3 quality in your settings. Try setting this higher or lower
  • you're downloading as file-per-chapter. Try as single-file
  • you're saving as mp3. Try as the default m4b (that is: uncheck the mp3 option)

I'm leaving town for a few days and I'll available for replies when I return.

@Mbucari Is this just an issue with a too-low sample rate?

Line 1596 from the log above (in their reply on Jan 15. 2 entries above this comment):

 {}2025-01-15 14:23:07.108 -05:00 [ERR] (at Dinah.Core.StepRunner.AsyncBaseStep+<RunAsync>d__2.MoveNext()) End step 'Step 2: Download Decrypted Audiobook'. FAILED. Completed in 00:00:00
System.AggregateException: One or more errors occurred. (Unsupported Sample Rate 7350 (Parameter 'format'))
 ---> System.ArgumentException: Unsupported Sample Rate 7350 (Parameter 'format')
   at NAudio.Lame.LameMP3FileWriter..ctor(Stream outStream, WaveFormat format, LameConfig config) in /home/runner/work/AAXClean.Codecs/AAXClean.Codecs/src/NAudio.Lame/LameMP3FileWriter.cs:line 150

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 16, 2025

@rmcrackan Yes, that is the issue. The MP# lib only supports 8000 Hz <= sample rates <= 48000 Hz. The AAXClean.SampleRate enum has values ranging from 7350 to 96000 because those are all possible values for an mp4 file, but the options in libation's MP3 settings will need to be restricted. I'll push a fix for it shortly. BTW, is there a reason that the current release is 11.1? There have been a lot of bug fixes since then.

@jacobfiala If you go to Libation's Audio File Settings and change "Max audio sample rate" to 8000, this should work.

@jacobfiala
Copy link
Author

That worked! Still getting the bad filter string error when I open it, but it works fine anyway!

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 16, 2025

@jacobfiala You probably have a corrupted QuickFilters.json file. Try deleting it (which will remove all quick filters you have set) and recreating your filters.

@jacobfiala
Copy link
Author

Yep! That was it. I'm back running perfectly. Thank y'all so much!

@rmcrackan
Copy link
Owner

Thank you @Mbucari !!!

is there a reason that the current release is 11.1? There have been a lot of bug fixes since then.

Fear. I actually did a full release a while back and too many users had issues with it so I deleted it. Every time I believe I've got it ironed out, someone on a pre-release will find something new. I just need to bite the bullet eventually. I'm not ready to though until I can have a lot of free time just in case there's a flood of bug reports after a new full release. And free time has not been abundant lately, so it's easy to put off.

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 21, 2025

@rmcrackan

I'm not ready to though until I can have a lot of free time just in case there's a flood of bug reports after a new full release.

When you're thinking of doing it, let me know ahead of time so we can coordinate a schedule where I can help find and fix bugs.

@rmcrackan
Copy link
Owner

When you're thinking of doing it, let me know ahead of time so we can coordinate a schedule where I can help find and fix bugs.

That would be very cool! I didn't know you were still interested. Would you prefer this week or next? Or other?

@Mbucari
Copy link
Collaborator

Mbucari commented Jan 23, 2025

That would be very cool! I didn't know you were still interested. Would you prefer this week or next? Or other?

The first week in February works better for me. You game for then?

@rmcrackan
Copy link
Owner

The first week in February works better for me. You game for then?

Sweet -- I added a calendar reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants