Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix multi-tenancy #224

Open
shurwit opened this issue Aug 22, 2022 · 1 comment · May be fixed by #359
Open

[BUG] Fix multi-tenancy #224

shurwit opened this issue Aug 22, 2022 · 1 comment · May be fixed by #359
Assignees
Labels
bug Something isn't working

Comments

@shurwit
Copy link
Collaborator

shurwit commented Aug 22, 2022

Describe the bug
Currently the Groups BB receives a "Client ID" through a a header with every request and uses this to manage multi-tenancy. This does not match with the app_id and org_id multi-tenancy model introduced by the Core BB and is not enforceable or consistent.

Expected behavior
We should use the app_id and org_id claims from a user's token to handle multi-tenancy and associate all related data with the specified app/org and ensure that users only get access to data for that app/org. The client ID and all related data should be removed. We will need to apply a migration to associate all existing groups and related data with the Illinois app/org. The IDs for the app/org can be found in the existing GROUPS_APP_ID and GROUPS_ORG_ID env vars.

Note: We may want to consider allowing groups to span across apps in the same org, but they must remain isolated by org at all times as previously discussed here: rokwire/content-building-block#63 (comment). For now I think we should start by keeping groups associated with both an app and org, but we should make the app_id nullable and handle it appropriately so we can add this functionality in the future.

@shurwit shurwit added the bug Something isn't working label Aug 22, 2022
@shurwit shurwit added this to the v2.0.0 milestone Aug 22, 2022
@shurwit shurwit assigned shurwit and unassigned roberlander2 Nov 17, 2022
@shurwit shurwit assigned roberlander2 and unassigned shurwit Jan 23, 2023
@shurwit shurwit removed this from the v2.0.0 milestone Jan 23, 2023
@roberlander2
Copy link
Collaborator

This will depend on #346.

@roberlander2 roberlander2 linked a pull request Feb 21, 2023 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants