Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix external ID handling #239

Open
shurwit opened this issue Aug 26, 2022 · 0 comments · May be fixed by #320
Open

[BUG] Fix external ID handling #239

shurwit opened this issue Aug 26, 2022 · 0 comments · May be fixed by #320
Assignees
Labels
bug Something isn't working
Milestone

Comments

@shurwit
Copy link
Collaborator

shurwit commented Aug 26, 2022

Describe the bug
Currently the external IDs are handled in separate external_id and net_id fields within the group member model. The net_id field is not set appropriately when first creating new member records.

Expected behavior
We should have a single external_ids map that stores the latest values of each of the external IDs in a user's token. These should be set whenever a new membership record is created, or if we notice that the external IDs in a user's token have changed.

For the moment, we should leave the external_id and net_id fields as deprecated fields for backwards compatibility, but once we have had a chance to review the impact and update the clients they can be removed completely.

@shurwit shurwit added the bug Something isn't working label Aug 26, 2022
@shurwit shurwit added this to the v2.0.0 milestone Aug 29, 2022
@shurwit shurwit added the good first issue Good for newcomers label Sep 26, 2022
@shurwit shurwit assigned bsdworkin and unassigned roberlander2 Oct 24, 2022
@bsdworkin bsdworkin linked a pull request Dec 19, 2022 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants