[FEATURE] Include sender, post content and action in group post notification body #457
Assignees
Labels
enhancement
New feature or request
Comments
mihail-varbanov
changed the title
mihail-varbanov
changed the title
mihail-varbanov
changed the title
18 tasks
18 tasks
mdryankov
added a commit
that referenced
this issue
Jun 24, 2024
|
I re-open this issue because there are still changes that need to be made. Here they are:
Reference: Comment |
18 tasks
shurwit
added a commit
to rokmetro/groups-building-block-fork
that referenced
this issue
Aug 14, 2024
* [rokwire#447] Groups BB rapid fixes and improvements (rokwire#449) * Ability to filter authman/manged groups [rokwire#441] * Admin APIs * Drop wrong logic related to the CanSendPostToAdmins flag * Rebuild api doc * Fix and rebuild * Update libraries * v1.38.0 * [rokwire#450] Improve group events APIs (rokwire#451) * [rokwire#450] Improve group events APIs * Rebuild api doc * v1.39.0 * [rokwire#452] Improve create group admin api (rokwire#453) Improve create group admin api rokwire#452 * v1.40.0 * [rokwire#452] improve create group admin api (rokwire#454) * Improve create group admin api rokwire#452 * [rokwire#452] Additional fix and cleanup * v1.40.1 * [rokwire#460] Fix missing member name and email for a managed group auto sync task (rokwire#461) * v1.40.2 * [rokwire#459] Introduce BBs APIs. Implement aggregate event users. (rokwire#462) * Introduce BBs APIs * Permissions. Part 1 * Report group as abuse * Introduce Auth2 for upcoming major refactoring in the near future * More fixes * Fix the policy * Resolve lint issues * Change log * v1.41.0 * Minor build fix * [ID-463]Delete everything from the database related to the core account (rokwire#464) * set the Changelog.md * in progress * in progress * delete group memberships * delete the users * delete posts * no message * pull members from event * fixes * delete members from posts * put in transaction * Make fixes. Improve the cron scheduler. Fix the index issue --------- Co-authored-by: Stefan Vitanov <[email protected]> Co-authored-by: Mladen Dryankov <[email protected]> * [rokwire#465] Add new permissions for managing group events independently for granтing access (rokwire#466) Add new permissions for managing group events independently for granting access [rokwire#465] * v1.42.0 * [rokwire#465] add new role for managing group events (rokwire#467) * Add new permissions for managing group events independently for granting access [rokwire#465] * Updated golang & alpine Docker container versions * [rokwire#456] Create Group Report Abuse API (rokwire#470) Create Group Report Abuse API [rokwire#456] * rovide Replies when loading single Post. Part 1 * Small fix * Fix and improve transactions handling * safety measure * [rokwire#468] provide nested replies single post api (rokwire#471) * rovide Replies when loading single Post. Part 1 * Small fix * Fix and improve transactions handling * safety measure * v1.43.0 * [rokwire#457] Include sender, post content and action in group post notification body (rokwire#472) Include sender, post content and action in group post notification body [rokwire#457] Send post notification only to the creator of the post [rokwire#372] * v1.44.0 * Use all_bbs_groups permissions for all BBs APIs [rokwire#473] * v1.45.0 * [rokwire#473] Use all_bbs_groups & get_aggregated-users permissions for BBs APIs (Additional change) (rokwire#474) Use all_bbs_groups & get_aggregated-users permissions for BBs APIs (Additional change) [rokwire#473] * 1.45.1 * Update direct messages notification pattern [rokwire#475] (rokwire#476) * 1.45.2 * [rokwire#458] Admin API for adding group members by NetIDs rokwire#458 (rokwire#478) * Prepare admin logic * More improvements and local fixes * More fixes and improvements * Changelog * Regenerate docs * Fix typo * Redo wrong commit * v1.46.0 * [rokwire#477] Do not send polls and direct message notifications as muted when they are not (rokwire#479) * [rokwire#477] Do not send polls and direct message notifications as muted when they are not * Gen api doc * v1.46.1 * [rokwire#457] Additional fix: Truncate the post body to 250 characters within the notification (rokwire#480) * Include sender, post content and action in group post notification body [rokwire#457] Send post notification only to the creator of the post [rokwire#372] * [rokwire#457] Additional fix: Truncate the post body to 250 characters within the notification * v1.46.2 * [rokwire#481] Use "get_groups" permission for loading user groups in the admin API (rokwire#482) Use "get_groups" permission for loading user groups in the admin API [rokwire#481] * v1.46.3 * fix merge issues --------- Co-authored-by: Mladen Dryankov <[email protected]> Co-authored-by: stefanvitanov <[email protected]> Co-authored-by: Stefan Vitanov <[email protected]> Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: shurwit <[email protected]>
roberlander2
added a commit
to rokmetro/groups-building-block-fork
that referenced
this issue
Jan 3, 2025
* [rokwire#447] Groups BB rapid fixes and improvements (rokwire#449) * Ability to filter authman/manged groups [rokwire#441] * Admin APIs * Drop wrong logic related to the CanSendPostToAdmins flag * Rebuild api doc * Fix and rebuild * Update libraries * v1.38.0 * [rokwire#450] Improve group events APIs (rokwire#451) * [rokwire#450] Improve group events APIs * Rebuild api doc * v1.39.0 * [rokwire#452] Improve create group admin api (rokwire#453) Improve create group admin api rokwire#452 * v1.40.0 * [rokwire#452] improve create group admin api (rokwire#454) * Improve create group admin api rokwire#452 * [rokwire#452] Additional fix and cleanup * v1.40.1 * [rokwire#460] Fix missing member name and email for a managed group auto sync task (rokwire#461) * v1.40.2 * [rokwire#459] Introduce BBs APIs. Implement aggregate event users. (rokwire#462) * Introduce BBs APIs * Permissions. Part 1 * Report group as abuse * Introduce Auth2 for upcoming major refactoring in the near future * More fixes * Fix the policy * Resolve lint issues * Change log * v1.41.0 * Minor build fix * [ID-463]Delete everything from the database related to the core account (rokwire#464) * set the Changelog.md * in progress * in progress * delete group memberships * delete the users * delete posts * no message * pull members from event * fixes * delete members from posts * put in transaction * Make fixes. Improve the cron scheduler. Fix the index issue --------- Co-authored-by: Stefan Vitanov <[email protected]> Co-authored-by: Mladen Dryankov <[email protected]> * [rokwire#465] Add new permissions for managing group events independently for granтing access (rokwire#466) Add new permissions for managing group events independently for granting access [rokwire#465] * v1.42.0 * [rokwire#465] add new role for managing group events (rokwire#467) * Add new permissions for managing group events independently for granting access [rokwire#465] * Updated golang & alpine Docker container versions * [rokwire#456] Create Group Report Abuse API (rokwire#470) Create Group Report Abuse API [rokwire#456] * rovide Replies when loading single Post. Part 1 * Small fix * Fix and improve transactions handling * safety measure * [rokwire#468] provide nested replies single post api (rokwire#471) * rovide Replies when loading single Post. Part 1 * Small fix * Fix and improve transactions handling * safety measure * v1.43.0 * [rokwire#457] Include sender, post content and action in group post notification body (rokwire#472) Include sender, post content and action in group post notification body [rokwire#457] Send post notification only to the creator of the post [rokwire#372] * v1.44.0 * Use all_bbs_groups permissions for all BBs APIs [rokwire#473] * v1.45.0 * [rokwire#473] Use all_bbs_groups & get_aggregated-users permissions for BBs APIs (Additional change) (rokwire#474) Use all_bbs_groups & get_aggregated-users permissions for BBs APIs (Additional change) [rokwire#473] * 1.45.1 * Update direct messages notification pattern [rokwire#475] (rokwire#476) * 1.45.2 * [rokwire#458] Admin API for adding group members by NetIDs rokwire#458 (rokwire#478) * Prepare admin logic * More improvements and local fixes * More fixes and improvements * Changelog * Regenerate docs * Fix typo * Redo wrong commit * v1.46.0 * [rokwire#477] Do not send polls and direct message notifications as muted when they are not (rokwire#479) * [rokwire#477] Do not send polls and direct message notifications as muted when they are not * Gen api doc * v1.46.1 * [rokwire#457] Additional fix: Truncate the post body to 250 characters within the notification (rokwire#480) * Include sender, post content and action in group post notification body [rokwire#457] Send post notification only to the creator of the post [rokwire#372] * [rokwire#457] Additional fix: Truncate the post body to 250 characters within the notification * v1.46.2 * [rokwire#481] Use "get_groups" permission for loading user groups in the admin API (rokwire#482) Use "get_groups" permission for loading user groups in the admin API [rokwire#481] * v1.46.3 * [ID-455]POST request for loading group members (rokwire#486) * add the Changelog.md * add GetGroupMemenrsV2 POST * Fix swagger and apidoc --------- Co-authored-by: Stefan Vitanov <[email protected]> Co-authored-by: Mladen Dryankov <[email protected]> * [ID-483]Groups Stats are not updated (rokwire#487) * add the Changelog.md * add update groups stats to the create and delete membership --------- Co-authored-by: Stefan Vitanov <[email protected]> * [ID-485]The value for "current_member" is not available in group json (rokwire#488) * set the Changelog.md * set current user to GetGroups --------- Co-authored-by: Stefan Vitanov <[email protected]> * update version to 1.48.0 * hotfix * [ID-490]Fix Groups Stats are not updated (rokwire#492) * set the Changelog.md * fix UpdateGroupStats function fro create and delete group member --------- Co-authored-by: Stefan Vitanov <[email protected]> * [rokwire#484] Approve all api (rokwire#491) * Main implementation * Final implementation * Update apidoc * update version to 1.48.0 * [ID-494]BBs Api for getting group memberships (rokwire#495) * set the Changelog.md * set the docs * Gets all related group memberships status and group title using userID * set the goupID in the response and set the permission * fix * fix FindGroupMembershipStatusAmdGroupTitle using Aggregation * fix the comments * Revert "fix the comments" This reverts commit a054f6e. --------- Co-authored-by: Stefan Vitanov <[email protected]> * update version to 1.49.0 * [ID-497] (rokwire#498) * set the Changelog.md * fix the aggregation pipeline --------- Co-authored-by: Stefan Vitanov <[email protected]> * [ID-500] Add "group_id" to the bbs get group membership API (rokwire#501) * add the Changelog.md * add the groupID to the response --------- Co-authored-by: Stefan Vitanov <[email protected]> * update version to 1.49.0 * [ID-503]Calendar events issues (rokwire#504) * set the Changelog.md * in progress * set bbs get events API using comma separated eventIDs * add groupIDs to CreateCalendarEvent bbs api * fix --------- Co-authored-by: Stefan Vitanov <[email protected]> * update the version to 1.51.0 * fix date * merge develop into main (rokwire#505) * [ID-503]Calendar events issues (rokwire#504) * set the Changelog.md * in progress * set bbs get events API using comma separated eventIDs * add groupIDs to CreateCalendarEvent bbs api * fix --------- Co-authored-by: Stefan Vitanov <[email protected]> * update the version to 1.51.0 * fix date --------- Co-authored-by: Stefan Vitanov <[email protected]> * [rokwire#509] Bad Authman sync for user who has alternative auth method for first login (rokwire#510) Bad Authman sync for user who has alternative auth method for first login [rokwire#509] * v1.51.1 * [rokwire#506] New Event notifications are not sent to Group members (rokwire#511) * New Event notifications are not sent to Group members [rokwire#506] * Add missed notification * v1.52.0 * [ID-513] FERPA issues for group memberships (rokwire#514) * set the Changelog.md * in progress * if ferpa account is true than all the fileds are emty string or nil for admin/group/{group-id}/members * fix the core function * fix comment * set protectByFerpa function --------- Co-authored-by: Stefan Vitanov <[email protected]> * update the version to 1.53.0 * [ID-517]Get groups membership by groupID BBs (rokwire#517) * add the Changelog.md * set the docs * add the permission * structure the API * add get user memberships by groupID --------- Co-authored-by: Stefan Vitanov <[email protected]> * update the version to 1.54.0 * [ID-521]BBs API to Get groups by group_ids (rokwire#522) * set the Changelog.md * set the get groups by groups id API * fix lint issue --------- Co-authored-by: Stefan Vitanov <[email protected]> * update version to 1.55.0 --------- Co-authored-by: Mladen Dryankov <[email protected]> Co-authored-by: stefanvitanov <[email protected]> Co-authored-by: Stefan Vitanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current notification for group posts is not quite meaningful and has duplicated data:
Please update the notification body to include the sender, the post content and the action had been taken (e.g. post, reply). Also, the notification for post reply should include only the audience that is involved to that post.
Mode details here: #4050, #2938.
P.S. Do not care for the length of the body text, the client will take care of that.
The text was updated successfully, but these errors were encountered: