Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RO with 12 existing ROs #7

Open
rootabeta opened this issue Oct 17, 2023 · 1 comment
Open

RO with 12 existing ROs #7

rootabeta opened this issue Oct 17, 2023 · 1 comment
Assignees
@rootabeta
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers minor Does not cause significant issues

Comments

@rootabeta
Copy link
Owner

Attempting to RO when the region already has 12 ROs may result in a failure to successfully appoint oneself.
This can be circumvented by changing line 286 in content.js from
if(encounteredSelf) {
to
if(encounteredSelf || other_ros.length == 12) {
This allows YAFFeather to dismiss an RO if it has not found itself, but there are 12 ROs, meaning one must be dismissed before appointing.

This allows YAFFeather to catch failed RO attempts due to no available RO slots.
@rootabeta rootabeta self-assigned this Oct 17, 2023
@rootabeta rootabeta added bug Something isn't working enhancement New feature or request good first issue Good for newcomers minor Does not cause significant issues labels Oct 17, 2023
@rootabeta
Copy link
Owner Author

Merged to beta in 8b89379, awaiting field tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootabeta rootabeta

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers minor Does not cause significant issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootabeta