Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get back on CRAN #55

Open
mpadge opened this issue May 6, 2024 · 2 comments
Open

Get back on CRAN #55

mpadge opened this issue May 6, 2024 · 2 comments

Comments

@mpadge
Copy link
Member

mpadge commented May 6, 2024

Got kicked off because package downloads binary objects in https://github.com/ropensci-review-tools/pkgstats/blob/main/configure#L4 and https://github.com/ropensci-review-tools/pkgstats/blob/main/tools/winlibs.R#L2-L3. Need to remove these and rewrite as optional internal functionality for windows and macos.
mpadge added a commit that referenced this issue May 6, 2024
@mpadge
rm configure, tools/winlibs.R for #55
327d506
mpadge added a commit that referenced this issue May 6, 2024
@mpadge
add .onLoad fn to replace configure, tools/winlibs.R for #55
76b0f40
@mpadge
Copy link
Member Author

mpadge commented Jul 5, 2024

Can now use the ami package function on_cran via briandconnelly/ami#14 to auto-download and install ctags binaries for windows + macos when !ami::on_cran().

mpadge added a commit that referenced this issue Jul 5, 2024
@mpadge
use ami::on_cran for #55
2de71f8
mpadge added a commit that referenced this issue Jul 5, 2024
@mpadge
provide full binary download details in .onLoad for #55
974c707
mpadge added a commit that referenced this issue Jul 5, 2024
@mpadge
use 'packageStartupMessage' for #55
61fdc2f
@mpadge
Copy link
Member Author

mpadge commented Jul 5, 2024

Can't submit until resolution of of r-lib/cpp11#355 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpadge