Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALIR71FL parser error #79

Open
jeffeaton opened this issue Feb 27, 2019 · 4 comments · Fixed by #80
Open

ALIR71FL parser error #79

jeffeaton opened this issue Feb 27, 2019 · 4 comments · Fixed by #80
Labels
parser exceptions odd files, and parser errors

Comments

@jeffeaton
Copy link
Collaborator 

> get_datasets("ALIR71FL.ZIP")
Downloading: 
Albania 2017 DHS Individual Recode Flat ASCII data (.dat) [ALIR71FL.ZIP]
Error: `labels` must be unique
>

sigh...
@jeffeaton
Copy link
Collaborator Author

I suspect this is a haven 2.1.0 issue. I tested on my desktop which had haven 2.0.0 and no problem. Then upgraded to 2.1.0 and got this error again.

@jeffeaton
Copy link
Collaborator Author

And here is the offending commit: tidyverse/haven@ac15324#diff-86ada8ebd93527eef8e311aaae238581

jeffeaton added a commit that referenced this issue Feb 27, 2019
@jeffeaton
remove duplicated values in labels; fixed issue #79
c728c4d
@jeffeaton jeffeaton mentioned this issue Feb 27, 2019
Merged
OJWatson added a commit that referenced this issue Feb 27, 2019
@OJWatson
Merge pull request #80 from ropensci/issue-79
8fe5a2d 
remove duplicated values in labels; fixed issue #79
OJWatson added a commit that referenced this issue Feb 28, 2019
@OJWatson
v0.6.2 corrections for #79 issue with haven labels
fdaa94d
@osymandius
Copy link

osymandius commented Aug 3, 2019 •
edited
Loading

Downloading: Mozambique 2003 DHS Individual Recode Flat ASCII data (.dat) [mzir41fl.zip] Error: labels must be unique

Downloading: Zambia 1996 DHS Individual Recode Flat ASCII data (.dat) [ZMIR31FL.ZIP] Error: labels must be unique

@jeffeaton jeffeaton reopened this Aug 3, 2019
jeffeaton added a commit that referenced this issue Aug 3, 2019
@jeffeaton
remove duplicated values in labels for parse_sps(); fixed issue #79
213a500 
The previous commit c728c4d only addressed this for parse_dcf().  This addressed the issue for datasets parsed with parse_sps().
@jeffeaton jeffeaton mentioned this issue Aug 3, 2019
Merged
@jeffeaton
Copy link
Collaborator Author

The issue here was that the previous update only resolved this issue for datasets parsed with parse_dcf(). These two datasets had duplicated labels and were parsed with parse_sps().

I've made a pull request, but in the meantime, you should be able to get a working version with
devtools::install_github("ropensci/rdhs@issue-79")

OJWatson added a commit that referenced this issue Aug 5, 2019
@OJWatson
Merge pull request #90 from ropensci/issue-79
d3a0698 
remove duplicated values in labels for parse_sps(); fixed issue #79
@OJWatson OJWatson added the parser exceptions odd files, and parser errors label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parser exceptions odd files, and parser errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove duplicated values in labels; fixed issue #79 ropensci/rdhs
3 participants
@jeffeaton @osymandius @OJWatson