Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rarity" option #17

Closed
ix0rai opened this issue Aug 10, 2023 · 0 comments
Closed

"rarity" option #17

ix0rai opened this issue Aug 10, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ix0rai
Copy link
Member

ix0rai commented Aug 10, 2023

currently, all colours have the same probability of showing up no matter what. as suggested in #16 by @emanuelal99, it would be a big improvement to have a configuration option for how often alt colours should appear.

my planned implementation is a percentage value:
a value of 25 would mean that 75% of squids are vanilla, and 25% would have custom colours.

discussion question: should this value apply no matter what, or only in packs of colours that include the vanilla colour for that entity? I'm thinking the former is the better options, since you can simply set it to 100% to always get custom.

@ix0rai ix0rai added the enhancement New feature or request label Aug 10, 2023
@ix0rai ix0rai self-assigned this Aug 10, 2023
Dariensg added a commit to Dariensg/rainglow that referenced this issue Oct 7, 2023
Solves rosebudmods#17

In doing this, I also discovered bugs with the Slime coloring. Slimes seem to ignore rarity, but I don't believe it's a fault of the rarity code. They also sometimes change colour upon touching the ground for the first time after being spawned. I think there's something else happening that's overriding their colours.
@ix0rai ix0rai closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant