Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-compiling example GLSL code section 3.2.6 (fix included) #49

Open
ben-horner opened this issue May 5, 2020 · 1 comment
Open

Non-compiling example GLSL code section 3.2.6 (fix included) #49

ben-horner opened this issue May 5, 2020 · 1 comment

Comments

@ben-horner
Copy link

In section 3.2.6, in the second code section the GLSL for the fragment shader:

varying vec4 v_color;
void main()
{
  gl_FragColor = color;
}

I think it should be gl_FragColor = v_color
I'm 100% new to opengl, and kinda new to python, this tripped me up for a while.

I think I have a slightly better sense of declaring input and output arguments to shaders look like (not exactly though) after having fiddled with that code until it worked.

I would have been able to proceed if the code worked though. :)

@rougier
Copy link
Owner

rougier commented May 14, 2020

Thanks ! I think you're right. Can you make a Pull Request? (you can do it through GitHub if you're not familiar with git)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants