Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the saved model objects #106

Open
AhmetCanSolak opened this issue Feb 11, 2022 · 0 comments
Open

Changing the saved model objects #106

AhmetCanSolak opened this issue Feb 11, 2022 · 0 comments
Assignees
Milestone

Comments

@AhmetCanSolak
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently we are saving aydin.it level objects when we save a trained model. This is working out well so far but it will be a bigger convenience if we can switch to aydin.restoration level objects. That way, we can incorporate selections on specific pre/post-processing options as well. Also this will help us to simplify some of the GUI and CLI related code pieces. Important to note: This will be a breaking change and users will not be able to use their previously trained models on the earlier versions of Aydin. We are promoting use of restoration level API, we use restoration level API both on CLI and GUI ourselves. We can make our saved models compatible at restoration level API too.

Describe the solution you'd like
Moving the business logic in aydin.it.base to aydin.restoration.denoise.base or maybe somewhere else to comfort deconvolution restorations too.

Describe alternatives you've considered
An alternative could be not making such breaking change but as we want to implement further features regarding saving/loading models, it only introduces more complications due to nature of our client code(which tries to stick to restoration level API).

@AhmetCanSolak AhmetCanSolak added this to the v0.2.0 milestone Feb 11, 2022
@AhmetCanSolak AhmetCanSolak self-assigned this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant