Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing figure 4 #1

Open
mathieuboudreau opened this issue Jan 26, 2024 · 6 comments
Open

Missing figure 4 #1

mathieuboudreau opened this issue Jan 26, 2024 · 6 comments
Assignees

Comments

@mathieuboudreau
Copy link
Contributor

@agahkarakuzu since some of your changes, Figure 4 has disapeared in my repo's build: https://rrsg2020.github.io/note

Do you have any idea why?

@mathieuboudreau
Copy link
Contributor Author

@agahkarakuzu Seems like there's an issue finding files from my dataset,

https://github.com/rrsg2020/note/blob/02178f761d27bab02414c4be132f8a109e4d1022/reports/index.log#L549C1-L551C134

I'll revert to my old data_requirements file, as it was setup to be compatible with my notebook (in terms of folder, etc). It was still inside ../data like the previous succesful neurolibre submission, so this one should work too I'd imagine

@mathieuboudreau
Copy link
Contributor Author

@agahkarakuzu I fixed the issue. Your updated config,

{
"src": "https://github.com/rrsg2020/analysis/releases/download/v1/rrsg-2020-neurolibre.zip",
"dst": "../data",
"projectName": "rrsg-2020-note"
}

wouldn't have worked, as after repo2data unzips from github, it would have made a folder ../data/rrsg-2020-note/rrsg-2020-neurolibre, but we need it to be ../data/rrsg-2020-neurolibre for it to be compatible with my notebook.

I revered it back to

{
"src": "https://github.com/rrsg2020/analysis/releases/download/v1/rrsg-2020-neurolibre.zip",
"dst": "../",
"projectName": "data"
}

which makes the correct directory config, and creates the folder ../data per the neurolirbe requirements

@mathieuboudreau
Copy link
Contributor Author

Ok it's now fixed in https://rrsg2020.github.io/note/, and figure 4 has reappeared. @agahkarakuzu take special notice as to how Figure 4 (WM-Splenium) appears in this current version; it does not have a few datapoints with very large error bars, unlike the latest NRP built by NeuroLibre: https://preview.neurolibre.org/book-artifacts/rrsg2020/github.com/note/e3a349c78003181502562f5bde1dc525a69ab234/_build/_page/index/singlehtml/, which for some reason is using my old dataset and not the one I currently have in my req in this repo

@agahkarakuzu
Copy link
Contributor

agahkarakuzu commented Jan 26, 2024

@mathieuboudreau

but we need it to be ../data/rrsg-2020-neurolibre for it to be compatible with my notebook.

Unfortunately we cannot do this, as that folder is already in use by the other one:

image

Also, if you use data for projectName, it will be under data/data/ during the notebook runtime. That projectName should be specific to this submission.

How complicated is it to make your notebooks compatible with ../data/rrsg-2020-note/rrsg-2020-neurolibre ?

For reference:

image

@mathieuboudreau
Copy link
Contributor Author

Ahhh, I understand everything now - sorry about that! Yes, I'll make it work, will report back ASAP! Thanks @agahkarakuzu !

@mathieuboudreau
Copy link
Contributor Author

Ok, should be done! Seems to work on this end!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants