fix build failures with gcc 13 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially seen in [Debian Bug#1037655], Filtlong fails to build with gcc 13. The relevant part of the build log looks like: In file included from src/read.h:25, from src/read.cpp:22: src/kmers.h:37:26: error: ‘uint32_t’ has not been declared 37 | bool is_kmer_present(uint32_t kmer); | ^~~~~~~~ src/kmers.h:39:5: error: ‘uint32_t’ does not name a type 39 | uint32_t starting_kmer_to_bits_forward(char * sequence); | ^~~~~~~~ src/kmers.h:25:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’? Adding cstdint to kmers.h per compiler hint allows the build to go through. [Debian Bug#1037655]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037655 Signed-off-by: Étienne Mollier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially seen in Debian Bug#1037655, Filtlong fails to build with gcc 13. The relevant part of the build log looks like:
Adding cstdint to kmers.h per compiler hint allows the build to go through.