Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Should quit when configuration is not valid #20

Open
lucas-dclrcq opened this issue Apr 17, 2023 · 1 comment
Open

Should quit when configuration is not valid #20

lucas-dclrcq opened this issue Apr 17, 2023 · 1 comment

Comments

@lucas-dclrcq
Copy link

First, thank you for this exporter ! This is exactly what I was looking for.

A suggestion, whenever the configuration fails against validation. Wouldn't it be better that the programs quits returning an error code ?

I've made an error on first try, and the pod kept running as if everything went fine (the config error was logged)

@rtrox
Copy link
Owner

rtrox commented Apr 27, 2023

Hey @lucas-dclrcq! Totally agree -- I've actually pulled this code into exportarr though, now, which you can find here:
https://github.com/onedr0p/exportarr

In that repo, we do actually exit fully when configuration is invalid. I'll be archiving this repo fairly soon, but the metrics are all identical in exportarr, as it's the same collector code. If you have trouble migrating to exportarr, let me know, glad to help you adjust configs and such!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants