Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly wrong width for overflow menu #208

Open
rugk opened this issue Jul 3, 2019 · 0 comments
Open

Possibly wrong width for overflow menu #208

rugk opened this issue Jul 3, 2019 · 0 comments
Labels
bug Something isn't working
Milestone
next

Comments

@rugk
Copy link
Owner

rugk commented Jul 3, 2019

Bug description

offline-qr-code/src/popup/qrcode.css

Line 21 in 7f755b4

@media (width: 425px) {

Actual behavior

As Im also stated on https://discourse.mozilla.org/t/can-add-ons-webextensions-popups-determinate-whether-they-are-shown-in-the-overflow-menu-or-not/27937/6, I hardcoded the size to 425px

Expected behavior

In my new tests I actually got window.innerWidth =348 .

Same value for .getClientRects() and getBoundingClientRect and window.matchMedia("(width: 348px)") and document.documentElement.clientWidth

System

Operating system and version:
Browser and version: Firefox 67 (also tested in FF 60 ESR)
Add-on version:

Possible solution
@rugk rugk added the bug Something isn't working label Jul 3, 2019
@Gitoffthelawn Gitoffthelawn mentioned this issue Jan 24, 2020
Closed
@rugk rugk added this to the v1.7 milestone Jan 24, 2020
@rugk rugk modified the milestones: v1.7, 2.0 May 31, 2020
@rugk rugk modified the milestones: 1.8, next Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@rugk