Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests covering Person operator field changes #21

Open
5 tasks
iamEAP opened this issue Dec 31, 2019 · 1 comment
Open
5 tasks

Add unit tests covering Person operator field changes #21

iamEAP opened this issue Dec 31, 2019 · 1 comment
Assignees
@amcpanaligan
Labels
bug Something isn't working

Comments

@iamEAP
Copy link
Contributor

iamEAP commented Dec 31, 2019

What / Why

Although not necessary to exercise every operator in tests (this should be covered by run-crank/typescript-cog-utilities#5), we should at least cover a few new branches of code and ensure the field is set correctly

Scope / UAT Target

  • Add operator field assertion in "expected step fields" test for SalesLoft Person Check Step
    • Field is set with expected key
    • Field is set to optional
  • Add error outcome assertion when util.compare throws UnknownOperatorError for SalesLoft Person Check Step
  • Add error outcome assertion when util.compare throws InvalidOperandError for SalesLoft Person Check Step
@iamEAP iamEAP added the bug Something isn't working label Dec 31, 2019
@amcpanaligan amcpanaligan self-assigned this Jan 2, 2020
@amcpanaligan
Copy link
Contributor

Oops! I cannot tick the boxes.

@amcpanaligan amcpanaligan mentioned this issue Jan 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcpanaligan amcpanaligan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamEAP @amcpanaligan