Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crunchy aggregator (and p2p-viz) yields incorrect node results #263

Open
autotunafish opened this issue Jan 30, 2025 · 0 comments
Open

Crunchy aggregator (and p2p-viz) yields incorrect node results #263

autotunafish opened this issue Jan 30, 2025 · 0 comments

Comments

@autotunafish
Copy link
Contributor

autotunafish commented Jan 30, 2025

I believe the issue (though it's basically a hunch) is that the crawler is incorrectly labeling node types as unknown (I think). When outputing the data with the following call "curl --data-binary '{"jsonrpc": "2.0", "id":0, "method": "getmetrics", "params": [] }' -H 'content-type: application/json' http://127.0.0.1:54321/ > crunchy/testdata/latest.json", and subsequently given to crunchy with the Zcash filter, it only returns the count of the protocol version "170018", of which there seems to be 16. I make this assumption based only on that number because thats the exact Zcash node count displayed in p2p-viz. I suppose the issue could be in crunchy but not sure. I couldn't really find where it compares protocol version to derive node type, this is what I suspect the issue to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant