Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for encoding framerate option #54

Open
lsr1006 opened this issue Jan 14, 2024 · 4 comments
Open

Request for encoding framerate option #54

lsr1006 opened this issue Jan 14, 2024 · 4 comments

Comments

@lsr1006
Copy link

lsr1006 commented Jan 14, 2024

It would be nice to be able to choose a framerate to record at, similar to the "--encode-resolution" option for resolution. I have a 170 Hz 1440p monitor but I really only want my recordings to be at 60 FPS. I have the bit-rate cranked up quite high to maintain the quality at this framerate which ends up making the file sizes too large for my liking. I don't want to downscale the resolution or sacrifice visual quality, reducing the FPS is really what I would prefer. I usually transcode clips down to 60FPS afterwards anyway, but it would be nice to not have to do that and not have to worry about available space while recording.

If this is already possible, my apologies. I didn't see any way with the current options.

@russelltg
Copy link
Owner

This is not currently possible, thank you for opening an issue.

There's no one ideal way to implement this, due the the VFR nature of screenrecording (unless you pass --no-damage, which is not suggested). Likely this could be implemented as a "minimum delta between frames"

Unfortunately, I'm not seeing any way in the wlr-screencopy API to avoid the buffer copies for the non-encoded frames, which would be nice (you don't get the frame timestamp until after it's been copied), but not required

@lsr1006
Copy link
Author

lsr1006 commented Jan 15, 2024

Understood, thanks for the response.

@LtdJorge
Copy link

LtdJorge commented Feb 1, 2024

Hi, can't this be done in the ffmpeg part by the fps filter?

Basic usage for the ffmpeg command line is explained here:
https://trac.ffmpeg.org/wiki/ChangingFrameRate

With further explanation here:
https://ffmpeg.org//ffmpeg-filters.html#fps

I don't know if this is feasible with ffmpeg_next, although I see that it provides filters.

@russelltg
Copy link
Owner

Maybe. Idk how well fps filter deals with VFR video.

Reminder that the best way to reduce filesize is setting --bitrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants