Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bust the sync cache when the token changes #212

Closed
dwainm opened this issue Mar 8, 2023 · 2 comments
Closed

Bust the sync cache when the token changes #212

dwainm opened this issue Mar 8, 2023 · 2 comments

Comments

@dwainm
Copy link
Collaborator

dwainm commented Mar 8, 2023

If you change your token (for the case of changing accounts or adding multiple accounts, see #211), we still return data from the previous account.

The synced cache should compare the config token against that token stored in the sync storage. If no new one exists, we should still use the old sync, but if a new/different one is present, we should bust the cache and potentially call sync again.

@dwainm
Copy link
Collaborator Author

dwainm commented Jun 2, 2023

Thanks for the fix, @kenliu!

@kenliu
Copy link
Collaborator

kenliu commented Jun 2, 2023

thanks goes to @HacDan for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants