Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up video.get_thumb to use Video.extensions #16

Open
sawall opened this issue Oct 17, 2014 · 1 comment
Open

clean up video.get_thumb to use Video.extensions #16

sawall opened this issue Oct 17, 2014 · 1 comment
Labels
Milestone

Comments

@sawall
Copy link
Owner

sawall commented Oct 17, 2014

This may actually require some significant refactoring to handle elegantly due to inheritance issues when get_exif_tags is called from album.py.

@sawall sawall added the cleanup label Oct 17, 2014
@sawall sawall added this to the 0.1.0 milestone Oct 17, 2014
@sawall
Copy link
Owner Author

sawall commented Oct 17, 2014

This includes image.get_thumb and video.get_thumb. I ported them both from settings in Sigal but it's being handled in a horrid way at the moment. Probably utils is the right place to put this sort of thing.

Also, ideally these should use Video.extensions instead of an explicit list of Video extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant