Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish version 0.10? #201

Closed
LeifW opened this issue Aug 10, 2018 · 10 comments
Closed

Publish version 0.10? #201

LeifW opened this issue Aug 10, 2018 · 10 comments
Milestone

Comments

@LeifW
Copy link

LeifW commented Aug 10, 2018

That's the version the README says to use, but apparently it's not on Maven central.

@sergiorussia
Copy link

@retronym @SethTisue ?

@SethTisue
Copy link
Member

I fixed the README in 4627fe0 to go back to recommending 0.9.7

@LeifW @sergiorussia are there particular changes on the master branch that you're interested in seeing released? or are you fine with continuing to use 0.9.7, and you only opened the issue because of what the readme said?

@retronym might it be time to roll 0.10?

@SethTisue

This comment has been minimized.

@SethTisue SethTisue added this to the 0.10 milestone Feb 4, 2019
@sergiorussia
Copy link

@SethTisue i think ppl are eager to get latest stability fixes and performance improvements anyways. can't say anything regarding new commits in master (there are a lot of them) but as for me and my colleagues we hope to see #89 some day closed - it's the most inconvenient thing ever about scala-async 😞 (Python's 3.5+ async-await feels so natural...)

@SethTisue
Copy link
Member

@retronym shall I roll 0.10 with whatever's currently on master?

SethTisue referenced this issue Feb 20, 2019
also upgrade Scala 2.12.4 -> 2.12.6
@retronym
Copy link
Member

retronym commented Apr 8, 2019

Just released 0.10.0 for Scala 2.12 and 2.13.0-M5.

@retronym retronym closed this as completed Apr 8, 2019
@SethTisue
Copy link
Member

2.13.0-M5.

RC1, surely :-)

@sergiorussia
Copy link

@retronym 0.10.0 depends on scala 2.12.8 - is that a minimum required version for java8? just found that simply raising scala-async version automatically bumped resulting scalaVersion from explicit 2.12.7 to implicit 2.12.8

@SethTisue
Copy link
Member

SethTisue commented Apr 8, 2019

@sergiorussia I'm not able to reproduce that:

% cat build.sbt 
scalaVersion := "2.12.7"
libraryDependencies += "org.scala-lang.modules" %% "scala-async" % "0.10.0"
% sbt
[info] Loading project definition from /Users/tisue/tmp/20190408-async/project
[info] Loading settings for project root-20190408-async from build.sbt ...
[info] Set current project to root-20190408-async (in build file:/Users/tisue/tmp/20190408-async/)
[info] sbt server started at local:///Users/tisue/.sbt/1.0/server/1622fdd1fff0618a1387/sock
sbt:root-20190408-async> show scalaVersion
[info] 2.12.7
sbt:root-20190408-async> show fullClasspath
[info] Updating ...
[info] downloading http://127.0.0.1:8081/artifactory/scala-ci-virtual/org/scala-lang/modules/scala-async_2.12/0.10.0/scala-async_2.12-0.10.0.jar ...
[info] 	[SUCCESSFUL ] org.scala-lang.modules#scala-async_2.12;0.10.0!scala-async_2.12.jar (63ms)
[info] Done updating.
[info] * Attributed(/Users/tisue/tmp/20190408-async/target/scala-2.12/classes)
[info] * Attributed(/Users/tisue/.sbt/boot/scala-2.12.7/lib/scala-library.jar)
[info] * Attributed(/Users/tisue/.ivy2/cache/org.scala-lang.modules/scala-async_2.12/jars/scala-async_2.12-0.10.0.jar)
[success] Total time: 4 s, completed Apr 8, 2019 11:13:30 PM

are you doing something different?

@sergiorussia
Copy link

@SethTisue i found the problemactic setting:

// build.sbt
libraryDependencies += "org.scala-lang.modules" %% "scala-async" % "0.10.0"
scalaVersion := "2.12.7"
updateOptions := updateOptions.value.withCachedResolution(true) // this one

gives

% sbt
sbt:scala-async> show fullClasspath
[warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] * Attributed(/tmp/scala-async/target/scala-2.12/classes)
[info] * Attributed(/home/sergio/.ivy2/cache/org.scala-lang.modules/scala-async_2.12/jars/scala-async_2.12-0.10.0.jar)
[info] * Attributed(/home/sergio/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.8.jar)
sbt:scala-async> evicted
[warn] Scala version was updated by one of library dependencies:
[warn] 	* org.scala-lang:scala-library:2.12.8 is selected over 2.12.7
[warn] 	    +- org.scala-lang.modules:scala-async_2.12:0.10.0     (depends on 2.12.8)
[warn] 	    +- org.scala-sbt.temp:temp-resolve-18600d70445dcfa751baddbe15c9cc73f9930718:1.0 (depends on 2.12.7)
[warn] To force scalaVersion, add the following:
[warn] 	scalaModuleInfo ~= (_.map(_.withOverrideScalaVersion(true)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants