Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events page no longer displays events #936

Closed
propensive opened this issue Jul 21, 2018 · 2 comments
Closed

Events page no longer displays events #936

propensive opened this issue Jul 21, 2018 · 2 comments

Comments

@propensive
Copy link
Contributor

The events page here,
https://www.scala-lang.org/events/
appears to momentarily display upcoming events, but quickly refreshes to display only a list of trainings.

I've not investigated why, but I've been relying for a while on this page to work out where in the world I need to be on any date. ;)

@Philippus
Copy link
Member

Philippus commented Jul 21, 2018

This is a regression introduced in #924. I've made a PR to fix it.
Ultimately the cause is too much code reuse between trainings and events. We've been bitten by it before. They are not so similar after all.

propensive added a commit that referenced this issue Jul 21, 2018
Don't render training data on events page, fixes #936
@propensive
Copy link
Contributor Author

Thank you, @Philippus! It's great that I can raise an issue like this and about an hour later someone steps up to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants