From 2bde0cc5d1234a80a8deed62c26771c2e04cd985 Mon Sep 17 00:00:00 2001 From: Stephen Hoekstra Date: Fri, 11 Oct 2024 11:37:54 +0200 Subject: [PATCH] fix: Remove unused SES forwarder alias The provider alias was removed from the ses-forwarder module a while ago, this commit fixes the warning we get that we are referencing something that does not exist. Signed-off-by: Stephen Hoekstra --- .gitignore | 3 +++ ses_accounts_mail_alias.tf | 13 +++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 498a389c..c02e013b 100644 --- a/.gitignore +++ b/.gitignore @@ -5,6 +5,9 @@ *.tfstate *.tfstate.* +# Lock files +.terraform.lock.hcl + # Crash log files crash.log diff --git a/ses_accounts_mail_alias.tf b/ses_accounts_mail_alias.tf index 0cc76fcf..83470a58 100644 --- a/ses_accounts_mail_alias.tf +++ b/ses_accounts_mail_alias.tf @@ -1,5 +1,6 @@ module "ses-root-accounts-mail-alias" { - #checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth + # checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth + count = var.ses_root_accounts_mail_forward != null ? 1 : 0 providers = { aws = aws, aws.route53 = aws } @@ -13,11 +14,11 @@ module "ses-root-accounts-mail-alias" { } module "ses-root-accounts-mail-forward" { - #checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS. - #checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS. - #checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment - count = var.ses_root_accounts_mail_forward != null ? 1 : 0 - providers = { aws = aws, aws.lambda = aws } + # checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS. + # checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS. + # checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment + + count = var.ses_root_accounts_mail_forward != null ? 1 : 0 source = "schubergphilis/mcaf-ses-forwarder/aws" version = "~> 0.3.0"