[Bug] Cutout downloads sometimes fail upon reprocessing

[manning-ncsa]

🐞 Bug Report

Cutout downloads sometimes fail upon reprocessing because there is a possible code path during the image download process in which the local variable status is accessed without being declared.

2025-01-02T15:29:49.727284414Z celery-worker-sed-3 [2025-01-02 15:29:49,726: WARNING/ForkPoolWorker-1434] task_register_item: TaskRegister object (312810)
2025-01-02T15:29:49.964583465Z celery-worker-sed-3 [2025-01-02 15:29:49,964: ERROR/ForkPoolWorker-1434] Task Image Download[a5feefe1-83cd-42c2-a5a7-beaa9f95dac9] raised unexpected: UnboundLocalError("cannot access local variable 'status' where it is not associated with a value")
2025-01-02T15:29:49.964615946Z celery-worker-sed-3 Traceback (most recent call last):
2025-01-02T15:29:49.964621477Z celery-worker-sed-3   File "/usr/local/lib/python3.11/site-packages/celery/app/trace.py", line 453, in trace_task
2025-01-02T15:29:49.964625053Z celery-worker-sed-3     R = retval = fun(*args, **kwargs)
2025-01-02T15:29:49.964628961Z celery-worker-sed-3                  ^^^^^^^^^^^^^^^^^^^^
2025-01-02T15:29:49.964632888Z celery-worker-sed-3   File "/usr/local/lib/python3.11/site-packages/celery/app/trace.py", line 736, in __protected_call__
2025-01-02T15:29:49.964636515Z celery-worker-sed-3     return self.run(*args, **kwargs)
2025-01-02T15:29:49.964639971Z celery-worker-sed-3            ^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-02T15:29:49.964644710Z celery-worker-sed-3   File "/app/host/transient_tasks.py", line 963, in image_download
2025-01-02T15:29:49.964648117Z celery-worker-sed-3     ImageDownload(transient_name).run_process()
2025-01-02T15:29:49.964709793Z celery-worker-sed-3   File "/app/host/base_tasks.py", line 319, in run_process
2025-01-02T15:29:49.964713530Z celery-worker-sed-3     status_message = self._run_process(transient)
2025-01-02T15:29:49.964716847Z celery-worker-sed-3                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-02T15:29:49.964720123Z celery-worker-sed-3   File "/app/host/transient_tasks.py", line 219, in _run_process
2025-01-02T15:29:49.964723629Z celery-worker-sed-3     message = download_and_save_cutouts(
2025-01-02T15:29:49.964727837Z celery-worker-sed-3               ^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-02T15:29:49.964731224Z celery-worker-sed-3   File "/app/host/cutouts.py", line 136, in download_and_save_cutouts
2025-01-02T15:29:49.964735662Z celery-worker-sed-3     elif status == 1:
2025-01-02T15:29:49.964738928Z celery-worker-sed-3          ^^^^^^
2025-01-02T15:29:49.964742244Z celery-worker-sed-3 UnboundLocalError: cannot access local variable 'status' where it is not associated with a value
2025-01-02T15:37:44.088799190Z celery-worker-sed-1 [2025-01-02 15:37:44,088: WARNING/ForkPoolWorker-1437] TNS DONE