Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking changes for 0.2.x #1

Open
scottlamb opened this issue Jan 26, 2022 · 0 comments
Open

breaking changes for 0.2.x #1

scottlamb opened this issue Jan 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@scottlamb
Copy link
Owner

scottlamb commented Jan 26, 2022

Things I'm considering fixing:

  • PasswordClient (and its friends plain and digest) return Result<_, String>. They should use a real std::error::Error impl instead.
  • Each digest type should probably be an individual optional dependency, rather than having digest pull in both md5 and sha2 crates. In particular, I think it's rare for servers to use the SHA digest types, and folks might not want to have that dependency.
  • Rename http_auth::digest::Algorithm::Sha512Trunc256 to Sha512_256 to match the change with sha2 version 0.10.0.
  • ParamValue should probably be called ParamValueRef for consistency with ChallengeRef.
  • http_auth::basic::BasicClient and http_auth::digest::DigestClient maybe should be http_auth::basic::Client and http_auth::digest::Client respectively to eliminate the "stuttering" in the type names.
  • http_auth::PasswordClientBuilder could just take a with method based on a trait that adds stuff to the client, avoiding the need for somewhat arbitrarily chosen distinct method names for the str vs ChallengeRef vs http::HeaderValue vs http::GetAll cases

Other suggestions welcome.

@scottlamb scottlamb added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant