Crash adding people to ban list

[sl-service-account]

BugSplat Key Crash 91873

Sample Version:
7.1.10.10800445603

Sample Callstack:

SecondLifeViewer!boost::detail::atomic_conditional_increment	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/smart_ptr/detail/sp_counted_base_std_atomic.hpp(53)
SecondLifeViewer!boost::detail::sp_counted_base::add_ref_lock	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/smart_ptr/detail/sp_counted_base_std_atomic.hpp(112)
SecondLifeViewer!boost::detail::shared_count::{ctor}	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/smart_ptr/detail/shared_count.hpp(679)
SecondLifeViewer!boost::shared_ptr::{ctor}	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/smart_ptr/shared_ptr.hpp(476)
SecondLifeViewer!boost::weak_ptr::lock	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/smart_ptr/weak_ptr.hpp(198)
SecondLifeViewer!boost::signals2::connection::connected	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/connection.hpp(274)
SecondLifeViewer!LLPanelGroupBulkImpl::onAvatarNameCache	C:/a/viewer/viewer/indra/newview/llpanelgroupbulk.cpp(163)
SecondLifeViewer!LLPanelGroupBulkImpl::addUsers	C:/a/viewer/viewer/indra/newview/llpanelgroupbulk.cpp(144)
SecondLifeViewer!boost::function_n > const &,std::vector > const &>::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/function/function_template.hpp(789)
SecondLifeViewer!LLFloaterAvatarPicker::onBtnSelect	C:/a/viewer/viewer/indra/newview/llfloateravatarpicker.cpp(248)
SecondLifeViewer!boost::_mfi::mf::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/mem_fn.hpp(74)
SecondLifeViewer!boost::_bi::list >::call_impl	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/bind.hpp(192)
SecondLifeViewer!boost::_bi::list >::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/bind.hpp(208)
SecondLifeViewer!boost::_bi::bind_t,boost::_bi::list > >::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/bind.hpp(321)
SecondLifeViewer!boost::detail::function::void_function_obj_invoker,boost::_bi::list > >,void,LLUICtrl *,LLSD const &>::invoke	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/function/function_template.hpp(101)
SecondLifeViewer!boost::function_n::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/function/function_template.hpp(789)
SecondLifeViewer!boost::signals2::detail::call_with_tuple_args::m_invoke	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/variadic_slot_invoker.hpp(105)
SecondLifeViewer!boost::signals2::detail::call_with_tuple_args::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/variadic_slot_invoker.hpp(90)
SecondLifeViewer!boost::signals2::detail::variadic_slot_invoker::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/variadic_slot_invoker.hpp(133)
SecondLifeViewer!boost::signals2::detail::slot_call_iterator_t,std::_List_iterator >,boost::signals2::slot >,boost::signals2::mutex> > > > >,boost::signals2::detail::connection_body >,boost::signals2::slot >,boost::signals2::mutex> >::dereference	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/slot_call_iterator.hpp(108)
SecondLifeViewer!boost::iterators::iterator_core_access::dereference	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/iterator/iterator_facade.hpp(631)
SecondLifeViewer!boost::iterators::detail::iterator_facade_base,std::_List_iterator >,boost::signals2::slot >,boost::signals2::mutex> > > > >,boost::signals2::detail::connection_body >,boost::signals2::slot >,boost::signals2::mutex> >,boost::signals2::detail::void_type,boost::iterators::single_pass_traversal_tag,boost::signals2::detail::void_type &,__int64,0,0>::operator*	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/iterator/iterator_facade.hpp(737)
SecondLifeViewer!boost::signals2::optional_last_value::operator(),std::_List_iterator >,boost::signals2::slot >,boost::signals2::mutex> > > > >,boost::signals2::detail::connection_body >,boost::signals2::slot >,boost::signals2::mutex> > >	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/optional_last_value.hpp(58)
SecondLifeViewer!boost::signals2::detail::combiner_invoker::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/result_type_wrapper.hpp(64)
SecondLifeViewer!boost::signals2::detail::signal_impl,int,std::less,boost::function,boost::function,boost::signals2::mutex>::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/signal_template.hpp(246)
SecondLifeViewer!boost::signals2::signal,int,std::less,boost::function,boost::function,boost::signals2::mutex>::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/signal_template.hpp(733)
SecondLifeViewer!LLUICtrl::onCommit	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(437)
SecondLifeViewer!LLButton::handleMouseUp	C:/a/viewer/viewer/indra/llui/llbutton.cpp(518)
SecondLifeViewer!LLMouseHandler::handleAnyMouseClick	C:/a/viewer/viewer/indra/llwindow/llmousehandler.cpp(53)
SecondLifeViewer!LLViewerWindow::handleAnyMouseClick	C:/a/viewer/viewer/indra/newview/llviewerwindow.cpp(1091)
SecondLifeViewer!LLViewerInput::handleMouse	C:/a/viewer/viewer/indra/newview/llviewerinput.cpp(1619)
SecondLifeViewer!LLViewerWindow::handleMouseUp	C:/a/viewer/viewer/indra/newview/llviewerwindow.cpp(1200)
SecondLifeViewer!`LLWindowWin32::mainWindowProc'::`72'::::operator()	C:/a/viewer/viewer/indra/llwindow/llwindowwin32.cpp(2673)
SecondLifeViewer!std::_Func_class::operator()	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.41.34120/include/functional(920)
SecondLifeViewer!LLWindowWin32::gatherInput	C:/a/viewer/viewer/indra/llwindow/llwindowwin32.cpp(2245)
SecondLifeViewer!LLAppViewer::doFrame	C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1438)
SecondLifeViewer!LLAppViewer::frame	C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1362)
SecondLifeViewer!wWinMain	C:/a/viewer/viewer/indra/newview/llappviewerwin32.cpp(499)
SecondLifeViewer!invoke_main	D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(118)
SecondLifeViewer!__scrt_common_main_seh	D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(288)
kernel32!BaseThreadInitThunk
ntdll!RtlUserThreadStart

[canny]

This issue has been linked to a Canny post: add a residents to the group ban list, viewer crash 🎉

[AtlasLinden]

Repro steps:

1. Open the Group info in the People floater
2. Go to Roles & Members
3. Select the Banned Residents tab
4. Select the Ban Resident(s) button
5. Choose a resident to ban via the Resident Picker
6. Crash!

[maxim-productengine]

Cherrypicked to ForeverFPS, so updating the milestone.

[canny]

This issue has been linked to a Canny post: Banning from group crashes viewer 🎉